[1/3] batman-adv: Remove unused function batadv_hash_delete

Message ID 1469143811-15498-1-git-send-email-sven@narfation.org (mailing list archive)
State Accepted, archived
Commit b9f4f99a926c9de798c6bd49d01632c07ee7c262
Delegated to: Sven Eckelmann
Headers

Commit Message

Sven Eckelmann July 21, 2016, 11:30 p.m. UTC
  Signed-off-by: Sven Eckelmann <sven@narfation.org>
---
 net/batman-adv/hash.h | 30 ------------------------------
 1 file changed, 30 deletions(-)
  

Comments

Sven Eckelmann Oct. 18, 2016, 11:27 a.m. UTC | #1
On Freitag, 22. Juli 2016 01:30:09 CEST Sven Eckelmann wrote:
> Signed-off-by: Sven Eckelmann <sven@narfation.org>
> ---
>  net/batman-adv/hash.h | 30 ------------------------------
>  1 file changed, 30 deletions(-)

Applied in b9f4f99a926c9de798c6bd49d01632c07ee7c262 [1].

Kind regards,
	Sven

[1] https://git.open-mesh.org/batman-adv.git/commit/b9f4f99a926c9de798c6bd49d01632c07ee7c262
  

Patch

diff --git a/net/batman-adv/hash.h b/net/batman-adv/hash.h
index cbbf870..557a704 100644
--- a/net/batman-adv/hash.h
+++ b/net/batman-adv/hash.h
@@ -61,36 +61,6 @@  void batadv_hash_set_lock_class(struct batadv_hashtable *hash,
 /* free only the hashtable and the hash itself. */
 void batadv_hash_destroy(struct batadv_hashtable *hash);
 
-/* remove the hash structure. if hashdata_free_cb != NULL, this function will be
- * called to remove the elements inside of the hash.  if you don't remove the
- * elements, memory might be leaked.
- */
-static inline void batadv_hash_delete(struct batadv_hashtable *hash,
-				      batadv_hashdata_free_cb free_cb,
-				      void *arg)
-{
-	struct hlist_head *head;
-	struct hlist_node *node, *node_tmp;
-	spinlock_t *list_lock; /* spinlock to protect write access */
-	u32 i;
-
-	for (i = 0; i < hash->size; i++) {
-		head = &hash->table[i];
-		list_lock = &hash->list_locks[i];
-
-		spin_lock_bh(list_lock);
-		hlist_for_each_safe(node, node_tmp, head) {
-			hlist_del_rcu(node);
-
-			if (free_cb)
-				free_cb(node, arg);
-		}
-		spin_unlock_bh(list_lock);
-	}
-
-	batadv_hash_destroy(hash);
-}
-
 /**
  *	batadv_hash_add - adds data to the hashtable
  *	@hash: storage hash table