From patchwork Thu Sep 15 08:41:00 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Andreas Pape X-Patchwork-Id: 16689 X-Patchwork-Delegate: sven@narfation.org Return-Path: X-Original-To: patchwork@open-mesh.org Delivered-To: patchwork@open-mesh.org Received: from open-mesh.org (localhost [IPv6:::1]) by open-mesh.org (Postfix) with ESMTP id 0F47681DEF; Thu, 15 Sep 2016 10:41:53 +0200 (CEST) Authentication-Results: open-mesh.org; dmarc=none header.from=phoenixcontact.com Received-SPF: None (no SPF record) identity=mailfrom; client-ip=62.157.123.121; helo=mail2.phoenixcontact.com; envelope-from=apape@phoenixcontact.com; receiver=b.a.t.m.a.n@lists.open-mesh.org Authentication-Results: open-mesh.org; dmarc=none header.from=phoenixcontact.com Received: from mail2.phoenixcontact.com (mail2.phoenixcontact.com [62.157.123.121]) by open-mesh.org (Postfix) with ESMTPS id D4E5781477 for ; Thu, 15 Sep 2016 10:41:49 +0200 (CEST) Received: from localhost.localdomain ([149.208.237.60]) by de-nice01.de.phoenixcontact.com with ESMTP id 2016091510414749-46192 ; Thu, 15 Sep 2016 10:41:47 +0200 From: Andreas Pape To: b.a.t.m.a.n@lists.open-mesh.org X-Mailer: git-send-email 1.7.0.4 X-MIMETrack: Itemize by SMTP Server on DE-NICE01/Hub/SRV/DE/Phoenix Contact at 15.09.2016 10:41:47, Serialize by ntm_grab.EXE on nemex02/spoke/SRV/DE/Phoenix Contact at 15.09.2016 10:41:44, Serialize complete at 15.09.2016 10:41:44, Itemize by ntm_grab.EXE on nemex02/spoke/SRV/DE/Phoenix Contact at 15.09.2016 10:41:44, Serialize by Router on nemex02/spoke/SRV/DE/Phoenix Contact at 15.09.2016 10:41:44 X-TNEFEvaluated: 1 Message-ID: <1473928860-30519-1-git-send-email-apape@phoenixcontact.com> Date: Thu, 15 Sep 2016 10:41:00 +0200 content-transfer-encoding: quoted-printable content-type: text/plain; charset="utf-8" Subject: [B.A.T.M.A.N.] [PATCH] batctl: optchar variable uses wrong type X-BeenThere: b.a.t.m.a.n@lists.open-mesh.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: The list for a Better Approach To Mobile Ad-hoc Networking List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: The list for a Better Approach To Mobile Ad-hoc Networking Errors-To: b.a.t.m.a.n-bounces@lists.open-mesh.org Sender: "B.A.T.M.A.N" The variable "optchar" used char instead of int leading to a non working batctl tp command as the while loop parsing the tp arguments with the getopt command is only left via the "default" case leaving the tp subcommand unusable. Using type char also lead to a compiler warning. Signed-off-by: Andreas Pape Reviewed-by: Sven Eckelmann --- tp_meter.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- 1.7.0.4 .................................................................. PHOENIX CONTACT ELECTRONICS GmbH Sitz der Gesellschaft / registered office of the company: 31812 Bad Pyrmont USt-Id-Nr.: DE811742156 Amtsgericht Hannover HRB 100528 / district court Hannover HRB 100528 Geschäftsführer / Executive Board: Ulrich Leidecker, Christoph Leifer diff --git a/tp_meter.c b/tp_meter.c index 7fe0d56..10dc2b9 100644 --- a/tp_meter.c +++ b/tp_meter.c @@ -395,7 +395,7 @@ int tp_meter(char *mesh_iface, int argc, char **argv) int ret = EXIT_FAILURE; int found_args = 1, read_opt = USE_BAT_HOSTS; uint32_t time = 0; - char optchar; + int optchar; struct nl_sock *listen_sock = NULL; struct tp_result result = { .error = 0,