[v3,0/5] use BIT_ULL for NL80211_STA_INFO_* attribute types
| Message ID | 1529229951-17730-1-git-send-email-omer.efrat@tandemg.com (mailing list archive) |
|---|---|
| Headers |
Return-Path: <b.a.t.m.a.n-bounces@lists.open-mesh.org> X-Original-To: patchwork@open-mesh.org Delivered-To: patchwork@open-mesh.org Received: from open-mesh.org (localhost [IPv6:::1]) by open-mesh.org (Postfix) with ESMTP id 7E85D81012; Sun, 17 Jun 2018 12:06:01 +0200 (CEST) Authentication-Results: open-mesh.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=tandemg.com header.i=@tandemg.com header.b="SoTwTrgl"; dkim-atps=neutral Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2a01:111:f400:fe0e::72a; helo=eur04-vi1-obe.outbound.protection.outlook.com; envelope-from=omer.efrat@tandemg.com; receiver=<UNKNOWN> Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on072a.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe0e::72a]) by open-mesh.org (Postfix) with ESMTPS id C1EBE80676 for <b.a.t.m.a.n@lists.open-mesh.org>; Sun, 17 Jun 2018 12:05:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tandemg.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=daHPbhzjP2QJjq4DWK1o4nsL1HH3H/GSPqZkiuQirkU=; b=SoTwTrglqWM5LSC/usCeSdwCRLvT5tSNaO62Idml8PTl4+PECiDUEdF7VmPlhnwJO0HVdhtmsykxWRTmsjp95se16GuSPFTdI4BN0pFz3rb0+XIOA9Ln4AroLN+woN9kuGzjfLAXHO+hLMrQXeGoOgChDt98nBfpgsdoS8a1hvg= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=omer.efrat@tandemg.com; Received: from omer-laptop.tandemg.local (37.142.120.98) by DB7PR02MB3625.eurprd02.prod.outlook.com (2603:10a6:5:1::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.863.17; Sun, 17 Jun 2018 10:05:56 +0000 From: Omer Efrat <omer.efrat@tandemg.com> To: linux-wireless@vger.kernel.org, netdev@vger.kernel.org, b.a.t.m.a.n@lists.open-mesh.org, devel@driverdev.osuosl.org Date: Sun, 17 Jun 2018 13:05:51 +0300 Message-Id: <1529229951-17730-1-git-send-email-omer.efrat@tandemg.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [37.142.120.98] X-ClientProxiedBy: AM5PR0402CA0023.eurprd04.prod.outlook.com (2603:10a6:203:90::33) To DB7PR02MB3625.eurprd02.prod.outlook.com (2603:10a6:5:1::18) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ed857ba9-b238-4de9-6365-08d5d439eb79 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(711020)(2017052603328)(7153060)(7193020); SRVR:DB7PR02MB3625; X-Microsoft-Exchange-Diagnostics: 1; DB7PR02MB3625; 3:emvt5e5H2ZJyndH/y7oDx1ZMW3J0VbbvFdrQY4QVRgAIawlIaROotW096plpxxYNW+5pM9vTZJIQ9qYoNhUKKK+4rKiM3AH2QYuR0KCRx+1AZ7TiA5Lfl1yw0T+/S+ZILUur4yXfWmEHj+Ni3E23wvP1WlmsS28zIr5WaHSYW3mwC+5e3eHT0F+u7D/Oh+ZHS5eTj4qKCfd177QJ+likXJUR27bDR+163SdwN6lv4txGN6t43toE84jyevaJVwAD; 25:PRJHLHt7zGEQtk0/x+xRQ3UV1OJWtUYY1ZbwogCMPJHRELpermnFcNbSp6r4S4L/bjhZIbQAQWmM3mG+KNDW07mBdsX5B7kpwMS/QxM0BwAlGGf8tFlQwvOqCQnM38lNG/I94zKFPuVRhYPBahV/ijKnf3HiwzW/V3Ym1L43b7nwy0o6uMmyDNMBv0RBA6mS9Lp8vpe4j/ms2OiMZRbTDuy446UfoR9rG/Md1fEhM0iHYFlkBlHWhwRb0yIdzvv6uvNQt/7vC6gEY5FeUuos5tgLOcms3tMBbuA4AkOVoekK0kpjAQsVYeRhp5U8s6L2WJZ/EtSM9jx6+WTNb6DX+g==; 31:e+3VPhvxbvr5GazhVx8fpsNSXqzOlz/6MdoukzBzfbwdCvoTytPsBmXtMjmI+m+BxhEDHKm0QtCBbmF827/LvXDIgkwVvcgvEJgQxSwtk45s6Q82PJ5IkcTX51oUHsSKL6Op6yK56I33zQVSD0qz2xB0aLx6nBvPgMstBPkq8is/NEjN3CrqnVPRyDFgAUTvaHaoV6Anhc5j6z/gdYmqQmY9azrFI0fr6SxzUArnIsY= X-MS-TrafficTypeDiagnostic: DB7PR02MB3625: X-Microsoft-Exchange-Diagnostics: 1; DB7PR02MB3625; 20:2aTwiGjTQPqvVWV72aBl/Y9Uew38ye7KQO2SKVylDWI+I6obtmhqU5mveKDjObTI0y4UVGj0I/YBnl5ft0u79DDQkrwHuGVogZ/BsaKfv8yKOvj1MgsAPLHPIgq7sX9NK08ggaVChw/Xlhul1KpF/C3HclPCno5z5Kwo6rJthgZ5hhTWF7JuNk+xD9tArqf1N2XFJKtMq+cFMfm7Am3Pe2zbiRJOJAttox4mN+dzC1Y2pppzKJIRH2YGHDcXGxBd4wjSGwFnDUOsMcAsEgKx5AzQHPsuLUpT0pxo5rS3qAi+51kggdZM+0TVYSwI1fZsch6TBH4rX9MhqHiLXpAfWA==; 4:IcoujpamOHLRDrKybUGjhLsSPgvs0M9frwfJSV08U1uAjrV376PahZ0UPGHQJkAcIyvaT7r+4Hb1Wk9ASEru2ENGL6no4XYR3r90T5lg3jxWGbkVH3mhF7g/8amm9GQnrvLVX6BpmvtQVaR/sBhsRpZB8wDWgN+0EmXd8MhJXj2sHIJJ3z1iaXzCdAZsgHazEPVm+j/M8nLGB/K7DYNLToCMNezStJzLo3gWaMgaiphtusqtFDnXBMG//yy5fU/YjpFUbx8rHIhVloUJZhZJpA== X-Microsoft-Antispam-PRVS: <DB7PR02MB3625CA2564D5871FA6134ED29A720@DB7PR02MB3625.eurprd02.prod.outlook.com> X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040522)(2401047)(8121501046)(5005006)(3231254)(944501410)(52105095)(10201501046)(3002001)(93006095)(93001095)(149027)(150027)(6041310)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123558120)(20161123560045)(6072148)(201708071742011)(7699016); SRVR:DB7PR02MB3625; BCL:0; PCL:0; RULEID:; SRVR:DB7PR02MB3625; X-Forefront-PRVS: 07063A0A30 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(396003)(376002)(39830400003)(39380400002)(346002)(366004)(189003)(199004)(81166006)(81156014)(51416003)(52116002)(386003)(6506007)(6666003)(186003)(16526019)(26005)(68736007)(5660300001)(6512007)(8936002)(50226002)(8676002)(2906002)(53936002)(6116002)(3846002)(478600001)(106356001)(105586002)(6486002)(15760500003)(4326008)(107886003)(25786009)(97736004)(86362001)(486006)(2616005)(7736002)(36756003)(16586007)(305945005)(47776003)(956004)(476003)(48376002)(316002)(50466002)(44832011)(66066001); DIR:OUT; SFP:1102; SCL:1; SRVR:DB7PR02MB3625; H:omer-laptop.tandemg.local; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: tandemg.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DB7PR02MB3625; 23:e+H4ob6XBPIKM5WIZrX9VCMv9itURYZkVjMvueLdb?= yxo0BB6VmTBHynk17wXd33No3VXivSzwoFv4FrSBONOq6ISgRg2RCiNY0On8KEQLk2vl+l6SGXGxUOTJecKpwfYKgGWIINQ4Ff84b21xGHflE0OTVgXWWUPp9nlusGHD2sFzpxx5Oxn3clZasrDgu4sJBFQmh4XmhVEJ0t+4KV71ShO2ViYzwxyi+5ZwzMUcov8biuHsCxg4HiBxX+fRl1Fkhn2UxzD6llM8rXZGPJAfCbFn5l9oD7/SDD+i4zY4K+6KjyL6qytQKCr/lfpD0EFayotyogAxElryyYeaLylyrkw4iLnHg9UZEZ2cZoSrg1hsnSfSciOEG+wrLNVLcOMeKNBRCkVFcFhIiHso+Yu0qPCOOPVFagIu2zZdRbuVDkSvlYpHpbvCVkOzguVsGxe4R9Re+nWz2xLmzzVyUfvF4icitKIB70j6qB7Pw1IARb2wNX9eH7jdc+Fbn5O1jlt9hKnGFFogLu7bOZw5EWW9akizQCYhI6RDmOmoYvNj940qCbSFmd9SBj6FcHROvegu0o7+GHOzmzrurCpxuTat2lKoOHm5NYIyy7f6bmKVsglbFLC2NCzQrB0MKsRX6jhVyS6nwbC2H1weS7bpzr5W28f2fKi0cfQS53nzpZhh9Ddt7Aal1u1t9RYePfjkY6pU/O2IQLPqFf7Otl/77FYz78F9ZvqhICOd8UFt/o4eKVe1Hg6fNIVN194CLhOBzJbx/NNPvImXxExDnsMGQ74grSZslHmBNOs4anKtZueSLUHz5yMJ4cOSSM7Tv9hfjn+iGk0Z4lgFy8Jfe1wfvevuPm/Gfo/o09go8mj8YwVBHPari1OJWsjlhVzdMd+D6uLjDCUEfHI/dvKKgrZ07dwj8nPYM8vFqokCD8hmHHRoA1xhsLuX4o0VlVdUobbDKY4ciJyzcxwfA6FGahrd34i0nPpDqcIg3VB4t8gFAxZTKYecvgBeRugeVjHBzhAw+y8bDfCDzJNb/ibLyIu4r/ZakigkSO7sJE8JjcQvrvQ7XJ4usMFbdKS3VYkCtGSZabFU2jxScNfgt9B0WpHmK9LREGPCU3dQjhKPAl7OMAfAY9LQQM4EKNqP3h9KS0YPUgeQSlmshr35DmiMO+wEXjAPw== X-Microsoft-Antispam-Message-Info: rFSegte9aEUVjB0jQbFw8SJEIdk4bf2raxwX6QGcM4wD/hGlLgVvxoZrtFF8CcMHKhognfwxDZYDPV97Zts6Cfmv3FqX7E4j7hQrE8LQPD5TiePaC/gKZ7CLL7JWrqO7Ht9EmIkarE21Nky4+RodLiQEgA+tr+/dzyAuUba1AS9zQbQ15o8bZp3A7qkNTOcs X-Microsoft-Exchange-Diagnostics: 1; DB7PR02MB3625; 6:uZIJu2k7y/3OBXx+QLLpw3HdZMbzI1B4bzQrcf89V7QXu+yl70IeMaveYfasgBTt3u8BAYEWp+Ei9xONm1jWrOWgofB7CacCX0kdw0SjYZamEWEASkwMxgAcQD7zNANUVIzVzWAsB+YfSmQxmHpAYm7aMcdqpJuiGMMddV0YVsNCGD6Ko88HTkVa8Fa835/DlBHFCqnad3TEBBmrR6vkLLdptaHsvc7F6YSMIR+T/9pfIZYNX+wrPsUR7va5BdAiqNZErpriRhTdP47dFztJNbbDo2Tm/gOOsrOWHP9XxXcpXiplVcf0g2pgp1FtJiuBshOG0dmdtF8+Ua6UhZYMavzlYLCw38RXF5y/+e0WN/AL3mqoOSF73Kx27OPnOQO3wuJSN9yyvvq4paKR9LMDOQ0dVCAc5Rn4jUeWxxuIqJG74DcDn/MQLETokG+F5Ge/7/h9BOcDvInM5YVC+hN9vg==; 5:Rcvx3hKVepjVn8MqWvNLBPDA69RGnOh704bcVzDk/OrepFEk+/RRBy1mOntbnZpcgFCrWlPoNToaOodNoUPXpgS5J2Nuh8kSt8ErAu6hmG4uY1hoQMmk3VmDoA9ASIn94SQm/x/YhM2LQTBQ4TdW22ikfhsRrTbHUdvafsCkQZ0=; 24:/7gqrf/RYU1j03jLYNn0Pe51vUYTeri6ovbW4EQTOOmCCwGkjW3STSVAZpTb848VT0CvbTBp3gAKcoZTNHySCw19aWv9qS17P8O1+uF2xXs= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DB7PR02MB3625; 7:KzTYOOCJeEw+L6bMa8+w2ark4pztLchdNOs3bMSK2NNd5el+rPnGvn9P1ZruDtJh/kbdKB364qrIY/D8clLUzoZ8q3DuXFzwNGaxRT1AM7VloJPvcKLd+O4+muKor4UiNVCGba8/P/lfSXP7gFxTNfm5U+a90tFyGvVOVkQ8MwKLbQ+lwLxENCyRrUyz+/HajpjFm+Mw5sjxwN41xtBapBWOGGSkOdDd9nPTfG5FFUULl2vELC7ip9eRpzJOZvsC X-OriginatorOrg: tandemg.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jun 2018 10:05:56.5334 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ed857ba9-b238-4de9-6365-08d5d439eb79 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: d690b55a-f04a-454b-9f62-fb1e25467a25 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR02MB3625 Subject: [B.A.T.M.A.N.] [PATCH v3 0/5] use BIT_ULL for NL80211_STA_INFO_* attribute types X-BeenThere: b.a.t.m.a.n@lists.open-mesh.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The list for a Better Approach To Mobile Ad-hoc Networking <b.a.t.m.a.n.lists.open-mesh.org> List-Unsubscribe: <https://lists.open-mesh.org/mm/options/b.a.t.m.a.n>, <mailto:b.a.t.m.a.n-request@lists.open-mesh.org?subject=unsubscribe> List-Archive: <http://lists.open-mesh.org/pipermail/b.a.t.m.a.n/> List-Post: <mailto:b.a.t.m.a.n@lists.open-mesh.org> List-Help: <mailto:b.a.t.m.a.n-request@lists.open-mesh.org?subject=help> List-Subscribe: <https://lists.open-mesh.org/mm/listinfo/b.a.t.m.a.n>, <mailto:b.a.t.m.a.n-request@lists.open-mesh.org?subject=subscribe> Reply-To: The list for a Better Approach To Mobile Ad-hoc Networking <b.a.t.m.a.n@lists.open-mesh.org> Cc: Omer Efrat <omer.efrat@tandemg.com> Errors-To: b.a.t.m.a.n-bounces@lists.open-mesh.org Sender: "B.A.T.M.A.N" <b.a.t.m.a.n-bounces@lists.open-mesh.org> |
Message
Omer Efrat
June 17, 2018, 10:05 a.m. UTC
The BIT macro uses unsigned long which some architectures handle as 32 bit and therefore might cause macro's shift to overflow when used on a value equals or larger than 32 (NL80211_STA_INFO_RX_DURATION and afterwards). Since 'filled' member in station_info changed to u64, BIT_ULL macro should be used with all NL80211_STA_INFO_* attribute types instead of BIT to prevent future possible bugs when one will use BIT macro for higher attributes by mistake. Note: The following patch series only does some code clean up. The previous versions mentioned a bug fix but it appears as a mix up with some local changes because NL80211_STA_INFO_TID_STATS value actually equals 31. Changes in v3: - Better phrasing commit messages due to the above note - Align patches to latest mac80211-next Omer Efrat (5): cfg80211: use BIT_ULL for NL80211_STA_INFO_* attribute types mac80211: use BIT_ULL for NL80211_STA_INFO_* attribute types batman-adv: use BIT_ULL for NL80211_STA_INFO_* attribute types wireless-drivers: use BIT_ULL for NL80211_STA_INFO_ attribute types staging: use BIT_ULL for NL80211_STA_INFO_* attribute types drivers/net/wireless/ath/ath10k/mac.c | 4 +- drivers/net/wireless/ath/ath6kl/cfg80211.c | 14 ++-- drivers/net/wireless/ath/wil6210/cfg80211.c | 18 ++--- .../broadcom/brcm80211/brcmfmac/cfg80211.c | 40 +++++------ drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c | 6 +- drivers/net/wireless/marvell/libertas/cfg.c | 12 ++-- drivers/net/wireless/marvell/mwifiex/cfg80211.c | 14 ++-- drivers/net/wireless/quantenna/qtnfmac/commands.c | 32 ++++----- drivers/net/wireless/rndis_wlan.c | 4 +- drivers/net/wireless/ti/wlcore/main.c | 2 +- drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 10 +-- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 14 ++-- drivers/staging/wlan-ng/cfg80211.c | 4 +- net/batman-adv/bat_v_elp.c | 2 +- net/mac80211/ethtool.c | 6 +- net/mac80211/sta_info.c | 84 +++++++++++----------- net/wireless/nl80211.c | 26 +++---- net/wireless/wext-compat.c | 10 +-- 18 files changed, 151 insertions(+), 151 deletions(-)