Message ID | 1529230014-17897-1-git-send-email-omer.efrat@tandemg.com (mailing list archive) |
---|---|
State | Superseded, archived |
Delegated to: | Simon Wunderlich |
Headers |
Return-Path: <b.a.t.m.a.n-bounces@lists.open-mesh.org> X-Original-To: patchwork@open-mesh.org Delivered-To: patchwork@open-mesh.org Received: from open-mesh.org (localhost [IPv6:::1]) by open-mesh.org (Postfix) with ESMTP id 8490A81012; Sun, 17 Jun 2018 12:07:03 +0200 (CEST) Authentication-Results: open-mesh.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=tandemg.com header.i=@tandemg.com header.b="LxkbVJJH"; dkim-atps=neutral Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2a01:111:f400:fe02::714; helo=eur01-db5-obe.outbound.protection.outlook.com; envelope-from=omer.efrat@tandemg.com; receiver=<UNKNOWN> Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0714.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe02::714]) by open-mesh.org (Postfix) with ESMTPS id 4D88D80676 for <b.a.t.m.a.n@lists.open-mesh.org>; Sun, 17 Jun 2018 12:07:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tandemg.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6ibvmfpmoLbIHIxxgp0HlBGXgKnrIcuHph4qQtugywI=; b=LxkbVJJHcBy42atNzCNIf9NSYc9hALQ6MBXzbEtPnQFluvUiczDpx+je3m8EjXwA+RktPgwOcLBbs5/OYoocphI2vSDgPdy1bG1d+oerliXnYSNhcAPH2cPyC2A0SNGbceAymTcbCt1kWRnYpqgS3GcRW4nz8zhsdhJJS5akIyw= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=omer.efrat@tandemg.com; Received: from omer-laptop.tandemg.local (37.142.120.98) by AM0PR02MB3620.eurprd02.prod.outlook.com (2603:10a6:208:3f::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.863.19; Sun, 17 Jun 2018 10:06:59 +0000 From: Omer Efrat <omer.efrat@tandemg.com> To: linux-wireless@vger.kernel.org, netdev@vger.kernel.org, b.a.t.m.a.n@lists.open-mesh.org Date: Sun, 17 Jun 2018 13:06:54 +0300 Message-Id: <1529230014-17897-1-git-send-email-omer.efrat@tandemg.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [37.142.120.98] X-ClientProxiedBy: LO2P265CA0076.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:8::16) To AM0PR02MB3620.eurprd02.prod.outlook.com (2603:10a6:208:3f::21) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1ad136ed-3e65-44f5-0e66-08d5d43a10f5 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(711020)(2017052603328)(7153060)(7193020); SRVR:AM0PR02MB3620; X-Microsoft-Exchange-Diagnostics: 1; AM0PR02MB3620; 3:PZPxenhzzx8vqaABubWVoetraPg+EsrFQAFbOouAliR3fPs5Zt8+jF4ZFBRUmT6758ZflvcXqN0DhrveF5SdLPZ4Qtu+J7oJb41izSiX5uzYuhU5tKmhsWhwH1L8CPxuDJBv5MhHGg8zLBYsQbUHPhTJZgE5dy8bI4VW+CaFzhqeacM9RtsLHK1WKmoTnb23UbAxWckqd1qs4U+wokMw533FMzgEZLO7SzGkeD7C2xWqIOQBir9hfF8YNN9h2bWx; 25:Q4Frs6YRyDJy6xkzxMLVpQ0m0sWFK6YeoBl+qBGSCrmib/56h/T+kCNI0G3lQEsg/ghfWqUXHs673CUkcYX5hVH7oqyLZryJuoOjxlwyI5hwN3VbRG4PfSRnjVTUgzrnmzfxhJ+4K2UZeJ7HUxJgYLMDJxlW9SMJp466ZHvF9cR6XOnUWquJgyoGtRE9Y6FQGnCwvQORJuFrgHyYMGz4HU2jG+T8OICgoVVhXsl0BEE+EgYtazxlyUoIzYsWsStT487C9iTmwsOiDHnZU8fhyNdujkJKMWF1fVjBRsc2G+th1tEWn4mISOxAvrwzPQEhJgnaTmwz8bwpqQcl4q8DGw==; 31:jicOvAc2OajRbWN8hfpu3tmuwHZSoIHmwkNobhSvrmjfeG5pAf57uUvCYY6n9HFKEsHqEUVVmdEvjZ+5anj/4E/dwtUmzFDnEYT14X+4tZpCHtD4SEH9CKXc6mLhCCjAkUqjgAY3VNllnfqX0gq+0vnUcDfEouicvq3Wq32IHLBBLsoyARVUy2n0fyuFLiDRCJfbZwTkR8VlsWdbTPaYxrdlHQOil/yqx3blicK5cdo= X-MS-TrafficTypeDiagnostic: AM0PR02MB3620: X-Microsoft-Exchange-Diagnostics: 1; AM0PR02MB3620; 20:nyY0yUbBs8QbOGdbFQX+3WR0mOBi54h6Qt8edQNx3nHigRKvTRY9FF3MDhjhYnUjyZz0LFQQu3mSuF70HZ8eCEWIvzmuklCdX5KQM4RcKlHzFTO2gVSw9v+oO1j4dva0K6sB04XB5Va/fWCcRs5A7EN2wEqOwkziExBAtVYdystHpvyju7WxbzzrOgVF1LfApIjZAeBG+bmR4K+JIqz5rxSa9+5bwp1lzxR0dY18Zl9REOGyAOL1v6YLAx40Pq7JGo/u4f/jE8F2BqlqXsEN43Bs9VJSiWVMCRvUi9BmTEEU0np6lyCg5TxFEfGs+/wwzI1d02DmfReC/O7ejTC7NA==; 4:eGPi3E42ajMCiky5OgVVHK24mVl7hpEs2KLo5Qq76PDIkPy/JYCbMAwNITjqHj/SgCjGDCetw5HeNG7xeYuLcpK5zmxLUKEn9VWu/oGembOY6QtXRG/PdggXg0adMO/D9MdeP/vp4oynT5yRlwzUZsYAahMCA5xsLlFvspZ23O57gUxdpdx/EKpUWVVbNzFDTrfcc1wDfOPkytUuE4GDqVN3CTnF4YoQFz/1wb2sNIT6xRKDGrepmN+EPHkMMN5YvkZagk/YdOQZk3LxBZG7lA== X-Microsoft-Antispam-PRVS: <AM0PR02MB362095762DD7E891428F06609A720@AM0PR02MB3620.eurprd02.prod.outlook.com> X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040522)(2401047)(5005006)(8121501046)(3231254)(944501410)(52105095)(10201501046)(3002001)(93006095)(93001095)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123564045)(20161123562045)(20161123560045)(6072148)(201708071742011)(7699016); SRVR:AM0PR02MB3620; BCL:0; PCL:0; RULEID:; SRVR:AM0PR02MB3620; X-Forefront-PRVS: 07063A0A30 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(366004)(39840400004)(39380400002)(376002)(346002)(396003)(189003)(199004)(6116002)(2616005)(68736007)(52116002)(51416003)(105586002)(106356001)(59450400001)(26005)(16526019)(6506007)(386003)(97736004)(186003)(478600001)(36756003)(44832011)(486006)(5660300001)(3846002)(50466002)(48376002)(956004)(476003)(6666003)(6486002)(2906002)(81156014)(8676002)(86362001)(50226002)(25786009)(8936002)(66066001)(53936002)(7736002)(47776003)(4326008)(107886003)(6512007)(16586007)(316002)(81166006)(15760500003)(305945005); DIR:OUT; SFP:1102; SCL:1; SRVR:AM0PR02MB3620; H:omer-laptop.tandemg.local; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: tandemg.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM0PR02MB3620; 23:8LA5Dj6vhpVxwBtf8nm63RXxsIYXwR0JLHRS01o7+?= kjWfy5PNAFMF7cSNdk+00AB9uzBDgj0KVhvJ2IAM+B3exGGiublmHs8hJs9Ec4ctiyoohxdvhoSPm5Vt3B5Uj7FLEMVGVimnTE2isTb/JsqlBKfY96ZNlCw+lKUlXummseg+rsDeopPWeBSRgl1+DuISGlnMiXu1lnA5zHIyVfPtKWeQX5+qvhKMRchoAEkehP7JHf9fAadr/fSlZenbrC/3IQxwq4JPnssGOTzoLMd6q+f+kqY3q2E23PYcNt5v3WGYTqFR2toPbcWjlMX8IJEq6qb9w0Gg5OtHxTzLRiWbDBbjOa6qNpYNFFPY8ueRS2HIWRJYbAjDCFiC0Xc89K0HMJCjGWew7b0+hwtP43s13H5vErl+ce0k9ALKSfpUS3vMDR+zockpA9oLKtliCbkdpZynmDqv2hyJFO1vH1EeeodOQc1nKQJRytI+PD5bcQNwaWaVF737FjVA7unH2Wnxw24eEm60/sp6Mk4FWnWOok8H24mgu8iIROLRgU1Dh1q0feqB0q44lm2NhtyQPE+U6HYx90sbaowAW6wl+H5aV9BKCpoXYuggrsRdXgGMsmdR5skidJ+ibIFtg6vHfkCFbGW1vvCUl22tiBarOrqGr+5Z2G1wU0+KyDuMyPq34NtTPH6+ZfNqTunvHR2EbcJmoRLaVQvxszLwSqjsU1ORn+u9B4SDqKa341LUFQ4NkYsJii8EXjpOp2x1l3SwuPaLvc2CKWLNqoJp8KDy3nSn0/MGGw3FfQkTfe4fUIPc5fu6fdH8SMJtSVelhI5oh/awCCD863AanmkTyTOpNVR5LzmPt0ZA0EQe9mb7/bK2jNm59PWdri3ZNjPDWA+SUzeD+jruH50a5/dGDGnY1IVngTWmdIBb6G8g3awQGG7zK7xirFJZY1c/pRAHl+eW8Oy+qzNQj5bPorcyVbOetD7IPznF777qV6IIyUrBGlyVz1JXQXe2nKpk6ApSa8BX3DpBUaSfQSJWOEgK4F3jbPerg6HgpCQDQb2YUVs4dQELeMYUSCKatYP8E3EEci6Wv2Kk5+FEf0LdNuAef4ifnNo5DMmfcqvo8yM3jAlfSnlHyOdmuqnF9JXu+6Vbsk3vEcsU54C7VMU1H92lHz3BY9PzLyfsb7LGTdlDUWx0w9/C6vGrbnswVeFeyFlZm4//Hxe X-Microsoft-Antispam-Message-Info: 1kX0ECp9cAN2D4wUpCbfjQtM+stR0ydsNJf2+mfhu/E51KFCyuZqZQWNXym3xug0ACQK4VifxXbLSItA7neAWm+GHSrlTT3N37RSMul7/NiPmJuBp1iZb8ZlfYAvFExXsuqVQdQQcxV4IKVnvZKjvNrQ0Np/6J0ba0H8WUe34SAZYmpGT9q/CrdX0T7U2Dv/ X-Microsoft-Exchange-Diagnostics: 1; AM0PR02MB3620; 6:WMQOGKfxiqh7LpjT2aEJR+GrqxVioJgBg+FbdUPqzOJs7413C2JBqw4XFiXo1CA91rGe0jhhW7tHMH53pp9EapBgJQrwe6uY+j4vRg9E+bZD8qy2TboL3kTcR0SW5/PfOgoXOdUeIPlVBA7eYIL22SGPVYSaoLUGUvix5y2wtkdhrSvhpj9cHxAxUgymHZdyYPbUqCdZD5WHJ/Y/UwvEB3i7Rn21X1v0gA+7rXGuSQWUqmhiAwOcOwXqqFYzNTl4OTPGsqBVfeCkUz9OntHara/OYuspRDIqMUErViF2WBvsXUDwHNiBrPp0MkZ7ckXtmMaiddh7OX96PmL/OCyyg283RIFLCsCo+4ndhJmsepcGNW4J41zTIJa8cjJjJeQk8mVZsXOuXTl2hW6rHRK42f43oPr/+xkCG14o6yoJd7D0ye4vLCl/eeeJTByg5pWEvYH4WJd8idw4zXhe4oA6EQ==; 5:eXxsms+Kk94B8FCOlmnJ9j1tlRR98VlLlMHCCbPLHdxJphSJRZQI1uvJK7xKFI7FkyC6YD29RAb4NYo6+oIfGSm/aP+kWaUJDhE7kFoLcq0vo34uj9J8P58oI59jS7i/59bKglF+/8SOOYQ67k5xlr+AknQ81/LB1N8EMwgnsE8=; 24:wwI5Yt5TOR235pvFfInixEcbyzdcUyEKI/a4z0Ta1CxK8N6Ft5AljafphAoRXY5RrluYBnb/tHFb9kSmDdVy+bQRstou8O/lytFvkBqXWM4= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; AM0PR02MB3620; 7:1Q6WZDFxrTKgTJKeUTRwwnHXJgdMslBzVGF7r5Ju59RG75/ir69adFowpglMbFdFLtPDG8kXn9zf9d+hC4Xf0Jllyccb4XwqWHtHIGZ8PRByLp4x/G0ufSVIhRyH93RryrRlz6kd313+MEweQylHqBgDFX1bFykL3RD57JUzCr46+8vaviwWHZfzCik4XNGe2guH4f/Owuo/Crfzd//RnefCTcrFSfaWcMSYTYQmzzS5nn8vCq64w839kFbMnFR1 X-OriginatorOrg: tandemg.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jun 2018 10:06:59.5586 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1ad136ed-3e65-44f5-0e66-08d5d43a10f5 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: d690b55a-f04a-454b-9f62-fb1e25467a25 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR02MB3620 Subject: [B.A.T.M.A.N.] [PATCH v3 3/5] batman-adv: use BIT_ULL for NL80211_STA_INFO_* attribute types X-BeenThere: b.a.t.m.a.n@lists.open-mesh.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The list for a Better Approach To Mobile Ad-hoc Networking <b.a.t.m.a.n.lists.open-mesh.org> List-Unsubscribe: <https://lists.open-mesh.org/mm/options/b.a.t.m.a.n>, <mailto:b.a.t.m.a.n-request@lists.open-mesh.org?subject=unsubscribe> List-Archive: <http://lists.open-mesh.org/pipermail/b.a.t.m.a.n/> List-Post: <mailto:b.a.t.m.a.n@lists.open-mesh.org> List-Help: <mailto:b.a.t.m.a.n-request@lists.open-mesh.org?subject=help> List-Subscribe: <https://lists.open-mesh.org/mm/listinfo/b.a.t.m.a.n>, <mailto:b.a.t.m.a.n-request@lists.open-mesh.org?subject=subscribe> Reply-To: The list for a Better Approach To Mobile Ad-hoc Networking <b.a.t.m.a.n@lists.open-mesh.org> Cc: Omer Efrat <omer.efrat@tandemg.com> Errors-To: b.a.t.m.a.n-bounces@lists.open-mesh.org Sender: "B.A.T.M.A.N" <b.a.t.m.a.n-bounces@lists.open-mesh.org> |
Series |
use BIT_ULL for NL80211_STA_INFO_* attribute types
|
|
Commit Message
Omer Efrat
June 17, 2018, 10:06 a.m. UTC
The BIT macro uses unsigned long which some architectures handle as 32 bit
and therefore might cause macro's shift to overflow when used on a value
equals or larger than 32 (NL80211_STA_INFO_RX_DURATION and afterwards).
Since 'filled' member in station_info changed to u64, BIT_ULL macro
should be used with all NL80211_STA_INFO_* attribute types instead of BIT
to prevent future possible bugs when one will use BIT macro for higher
attributes by mistake.
This commit cleans up all usages of BIT macro with the above field
in batman-adv by changing it to BIT_ULL instead.
Signed-off-by: Omer Efrat <omer.efrat@tandemg.com>
---
net/batman-adv/bat_v_elp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On Sonntag, 17. Juni 2018 12:06:54 CEST Omer Efrat wrote: [...] > --- a/net/batman-adv/bat_v_elp.c > +++ b/net/batman-adv/bat_v_elp.c > @@ -114,7 +114,7 @@ static u32 batadv_v_elp_get_throughput(struct batadv_hardif_neigh_node *neigh) > } > if (ret) > goto default_throughput; > - if (!(sinfo.filled & BIT(NL80211_STA_INFO_EXPECTED_THROUGHPUT))) > + if (!(sinfo.filled & BIT_ULL(NL80211_STA_INFO_EXPECTED_THROUGHPUT))) > goto default_throughput; > > return sinfo.expected_throughput / 100; > WARNING: line over 80 characters #32: FILE: net/batman-adv/bat_v_elp.c:117: + if (!(sinfo.filled & BIT_ULL(NL80211_STA_INFO_EXPECTED_THROUGHPUT))) total: 0 errors, 1 warnings, 0 checks, 8 lines checked Kind regards, Sven
diff --git a/net/batman-adv/bat_v_elp.c b/net/batman-adv/bat_v_elp.c index 71c20c1..71e6474 100644 --- a/net/batman-adv/bat_v_elp.c +++ b/net/batman-adv/bat_v_elp.c @@ -114,7 +114,7 @@ static u32 batadv_v_elp_get_throughput(struct batadv_hardif_neigh_node *neigh) } if (ret) goto default_throughput; - if (!(sinfo.filled & BIT(NL80211_STA_INFO_EXPECTED_THROUGHPUT))) + if (!(sinfo.filled & BIT_ULL(NL80211_STA_INFO_EXPECTED_THROUGHPUT))) goto default_throughput; return sinfo.expected_throughput / 100;