Message ID | 20091213190149.GA22421@pandem0nium |
---|---|
State | Superseded, archived |
Headers | show |
On Sun, Dec 13, 2009 at 08:01:49PM +0100, Simon Wunderlich wrote: > Hello Andrew, > > i've checked your patch against older kernel, and there seem to be some > compile problems. E.g. compiling against 2.6.26, i find: > > CC [M] /home/dotslash/msrc/batman-svn/batman-adv-kernelland/bat_printk.o > /home/dotslash/msrc/batman-svn/batman-adv-kernelland/bat_printk.c: In function ???pointer???: > /home/dotslash/msrc/batman-svn/batman-adv-kernelland/bat_printk.c:564: error: implicit declaration of function ???dereference_function_descriptor??? > /home/dotslash/msrc/batman-svn/batman-adv-kernelland/bat_printk.c:564: warning: assignment makes pointer from integer without a cast > > against 2.6.21, there are a lot more lines of warnings and errors, while > 2.6.20 works mostly fine. Could you please review your patch in this regard? > I have nearly all kernels installed so i can give you a list of compile logs if you > are interested. Hi Simon I just posted an updated version of the patch. It would be great if you could test it on a few different kernels. I tried 2.6.21. bat_printk.c now compiles, but other parts of batman-adv fail. I think it was your skbuff patches which broke it, but i could be wrong. Andrew
Index: Makefile.kbuild =================================================================== --- Makefile.kbuild (revision 1491) +++ Makefile.kbuild (working copy) @@ -32,4 +32,5 @@ endif obj-m += batman-adv.o -batman-adv-objs := main.o proc.o send.o routing.o soft-interface.o device.o translation-table.o bitarray.o hash.o ring_buffer.o vis.o hard-interface.o aggregation.o originator.o +batman-adv-objs := main.o proc.o send.o routing.o soft-interface.o device.o translation-table.o bitarray.o hash.o ring_buffer.o vis.o hard-interface.o aggregation.o originator.o $(shell [ "2" -eq "$(VERSION)" ] && [ "6" -eq "$(PATCHLEVEL)" ] && [ "$(SUBLEVEL)" -le "28" ] && echo bat_printk.o) +