diff mbox

[batman-adv] Set the txqueuelen to zero when creating soft interface.

Message ID 20110323121503.GK6239@lunn.ch (mailing list archive)
State Accepted, archived
Commit a2f8a49168d145e30f12523badfaaea32207ddf4
Headers

Commit Message

Andrew Lunn March 23, 2011, 12:15 p.m. UTC 
  From e03cb760a296b55138dd6507b5e676c22cecf37e Mon Sep 17 00:00:00 2001
From: Andrew Lunn <andrew@lunn.ch>
Date: Mon, 21 Mar 2011 21:31:44 +0100
Subject: [PATCH] [batman-adv] Set the txqueuelen to zero when creating soft interface.

Like other virtual interfaces, e.g. br0, we don't need a transmit
queue. Packets should only be queued on real interfaces which are
underneath. In practice this patch makes little difference since the
virtual interfaces can accept packets as fast as they come, but the
patch will avoid bufferbloat questions to the mailling lists in the
future.

Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Tested-by: Linus Luesing <linus.luessing@web.de>
---
 soft-interface.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

Comments

Marek Lindner March 31, 2011, 3:48 p.m. UTC | #1 
On Wednesday 23 March 2011 13:15:03 Andrew Lunn wrote:
> Like other virtual interfaces, e.g. br0, we don't need a transmit
> queue. Packets should only be queued on real interfaces which are
> underneath. In practice this patch makes little difference since the
> virtual interfaces can accept packets as fast as they come, but the
> patch will avoid bufferbloat questions to the mailling lists in the
> future.
> 
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> Tested-by: Linus Luesing <linus.luessing@web.de>

Applied in revision ga2f8a49.

Thanks,
Marek
diff mbox

Patch

diff --git a/soft-interface.c b/soft-interface.c
index 9ed2614..7230e33 100644
--- a/soft-interface.c
+++ b/soft-interface.c
@@ -524,6 +524,7 @@  static void interface_setup(struct net_device *dev)
 	dev->hard_start_xmit = interface_tx;
 #endif
 	dev->destructor = free_netdev;
+	dev->tx_queue_len = 0;
 
 	/**
 	 * can't call min_mtu, because the needed variables