Message ID | 20120411130301.GD19365@ritirata.org |
---|---|
State | Not Applicable, archived |
Headers | show |
From: Antonio Quartulli <ordex@autistici.org> Date: Wed, 11 Apr 2012 15:03:03 +0200 > git://git.open-mesh.org/linux-merge.git tags/batman-adv-for-davem > > for you to fetch changes up to 7a5cc24277b57ce38eb0afa6634b71d4d5cc671e: > > batman-adv: add bridge loop avoidance compile option (2012-04-11 14:29:00 +0200) Pulled, but I think the way you're doing the bridge loop avoidance stuff is wrong. Don't use a Kconfig option, use a sysctl to turn the behavior off or on at runtime instead.
On Wed, Apr 11, 2012 at 09:58:09 -0400, David Miller wrote: > From: Antonio Quartulli <ordex@autistici.org> > Date: Wed, 11 Apr 2012 15:03:03 +0200 > > > git://git.open-mesh.org/linux-merge.git tags/batman-adv-for-davem > > > > for you to fetch changes up to 7a5cc24277b57ce38eb0afa6634b71d4d5cc671e: > > > > batman-adv: add bridge loop avoidance compile option (2012-04-11 14:29:00 +0200) > > Pulled, but I think the way you're doing the bridge loop avoidance stuff > is wrong. > > Don't use a Kconfig option, use a sysctl to turn the behavior off or on > at runtime instead. Hello David and thank you for your feedback. Actually we have either the Kconfig option (for binary size purposes) AND a boolean attribute in our soft_interface sysfs path (to dynamically turn the bridge loop avoidance ON and OFF as you were suggesting). Regards,
From: Antonio Quartulli <ordex@autistici.org> Date: Wed, 11 Apr 2012 16:31:03 +0200 > Actually we have either the Kconfig option (for binary size purposes) AND a > boolean attribute in our soft_interface sysfs path (to dynamically turn the > bridge loop avoidance ON and OFF as you were suggesting). Distributions are just going to turn on everything, so for %99.999 of users you really aren't saving anything.
It is not like that for a lot of batman-adv users that works with embedded devices where even 10KB makes the dfference On 04/11/12 16:39, David Miller wrote: > From: Antonio Quartulli <ordex@autistici.org> > Date: Wed, 11 Apr 2012 16:31:03 +0200 > >> Actually we have either the Kconfig option (for binary size purposes) AND a >> boolean attribute in our soft_interface sysfs path (to dynamically turn the >> bridge loop avoidance ON and OFF as you were suggesting). > > Distributions are just going to turn on everything, so for %99.999 of > users you really aren't saving anything.
From: Gioacchino Mazzurco <gmazzurco89@gmail.com> Date: Wed, 11 Apr 2012 16:43:43 +0200 > It is not like that for a lot of batman-adv users that works with > embedded devices where even 10KB makes the dfference Ok, but you also have the option of making it a seperate module too. Right now it's an all or nothing choice. Once you make a Kconfig decision, later it's harder to rebuild the kernel to fix a mistake than to simply load the module in question.