[1/2] batman-adv: remove useless forward declarations
Commit Message
If main.h is included, the batman-adv private forward declarations are
not needed anymore. Remove them.
Cc: Sven Eckelmann <sven@narfation.org>
Signed-off-by: Antonio Quartulli <a@unstable.cc>
---
net/batman-adv/gateway_client.h | 1 -
net/batman-adv/icmp_socket.h | 2 --
2 files changed, 3 deletions(-)
Comments
On Saturday 21 May 2016 20:17:55 Antonio Quartulli wrote:
> If main.h is included, the batman-adv private forward declarations are
> not needed anymore. Remove them.
No, these are defined in packet.h and not main.h/types.h
Kind regards,
Sven
> net/batman-adv/gateway_client.h | 1 -
> net/batman-adv/icmp_socket.h | 2 --
> 2 files changed, 3 deletions(-)
>
> diff --git a/net/batman-adv/gateway_client.h
> b/net/batman-adv/gateway_client.h index 582dd8c..c74aca5 100644
> --- a/net/batman-adv/gateway_client.h
> +++ b/net/batman-adv/gateway_client.h
> @@ -22,7 +22,6 @@
>
> #include <linux/types.h>
>
> -struct batadv_tvlv_gateway_data;
> struct seq_file;
> struct sk_buff;
>
> diff --git a/net/batman-adv/icmp_socket.h b/net/batman-adv/icmp_socket.h
> index 618d5de..ce3ed25 100644
> --- a/net/batman-adv/icmp_socket.h
> +++ b/net/batman-adv/icmp_socket.h
> @@ -22,8 +22,6 @@
>
> #include <linux/types.h>
>
> -struct batadv_icmp_header;
> -
> #define BATADV_ICMP_SOCKET "socket"
>
> void batadv_socket_init(void);
On Sat, May 21, 2016 at 02:30:01PM +0200, Sven Eckelmann wrote:
> On Saturday 21 May 2016 20:17:55 Antonio Quartulli wrote:
> > If main.h is included, the batman-adv private forward declarations are
> > not needed anymore. Remove them.
>
> No, these are defined in packet.h and not main.h/types.h
Right. This single patch can be dropped then.
Cheers,
On Saturday, May 21, 2016 20:17:55 Antonio Quartulli wrote:
> If main.h is included, the batman-adv private forward declarations are
> not needed anymore. Remove them.
>
> Cc: Sven Eckelmann <sven@narfation.org>
> Signed-off-by: Antonio Quartulli <a@unstable.cc>
> ---
> net/batman-adv/gateway_client.h | 1 -
> net/batman-adv/icmp_socket.h | 2 --
> 2 files changed, 3 deletions(-)
Applied in revision 563823d.
Thanks,
Marek
@@ -22,7 +22,6 @@
#include <linux/types.h>
-struct batadv_tvlv_gateway_data;
struct seq_file;
struct sk_buff;
@@ -22,8 +22,6 @@
#include <linux/types.h>
-struct batadv_icmp_header;
-
#define BATADV_ICMP_SOCKET "socket"
void batadv_socket_init(void);