diff mbox

batman-adv: move include line at the same place as other files

Message ID 20160521121756.27450-2-a@unstable.cc (mailing list archive)
State Accepted, archived
Commit 03619f9888a74f99f1f2c67980ab983bb0ff1ad4
Delegated to: Marek Lindner
Headers

Commit Message

Antonio Quartulli May 21, 2016, 12:17 p.m. UTC 
  main.h is always included after the #ifdef guard except for
bat_v_elp.h. Move it at the right place.

Cc: Sven Eckelmann <sven@narfation.org>
Signed-off-by: Antonio Quartulli <a@unstable.cc>
---
 net/batman-adv/bat_v_elp.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Sven Eckelmann May 21, 2016, 12:32 p.m. UTC | #1 
On Saturday 21 May 2016 20:17:56 Antonio Quartulli wrote:
> main.h is always included after the #ifdef guard except for
> bat_v_elp.h. Move it at the right place.
> 
> Cc: Sven Eckelmann <sven@narfation.org>
> Signed-off-by: Antonio Quartulli <a@unstable.cc>
> ---

Good find :)

Reviewed-by: Sven Eckelmann <sven@narfation.org>

Kind regards,
	Sven

>  net/batman-adv/bat_v_elp.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/net/batman-adv/bat_v_elp.h b/net/batman-adv/bat_v_elp.h
> index cc130b2..be17c0b 100644
> --- a/net/batman-adv/bat_v_elp.h
> +++ b/net/batman-adv/bat_v_elp.h
> @@ -15,11 +15,11 @@
>   * along with this program; if not, see <http://www.gnu.org/licenses/>.
>   */
> 
> -#include "main.h"
> -
>  #ifndef _NET_BATMAN_ADV_BAT_V_ELP_H_
>  #define _NET_BATMAN_ADV_BAT_V_ELP_H_
> 
> +#include "main.h"
> +
>  struct sk_buff;
>  struct work_struct;
Marek Lindner June 6, 2016, 4:12 p.m. UTC | #2 
On Saturday, May 21, 2016 14:32:38 Sven Eckelmann wrote:
> Signed by sven@narfation.org.	Show Details
> 
> On Saturday 21 May 2016 20:17:56 Antonio Quartulli wrote:
> > main.h is always included after the #ifdef guard except for
> > bat_v_elp.h. Move it at the right place.
> >
> > Cc: Sven Eckelmann <sven@narfation.org>
> > Signed-off-by: Antonio Quartulli <a@unstable.cc>
> > ---
> 
> Good find
> 
> Reviewed-by: Sven Eckelmann <sven@narfation.org>

Applied in revision f47544c.

Thanks,
Marek
diff mbox

Patch

diff --git a/net/batman-adv/bat_v_elp.h b/net/batman-adv/bat_v_elp.h
index cc130b2..be17c0b 100644
--- a/net/batman-adv/bat_v_elp.h
+++ b/net/batman-adv/bat_v_elp.h
@@ -15,11 +15,11 @@ 
  * along with this program; if not, see <http://www.gnu.org/licenses/>.
  */
 
-#include "main.h"
-
 #ifndef _NET_BATMAN_ADV_BAT_V_ELP_H_
 #define _NET_BATMAN_ADV_BAT_V_ELP_H_
 
+#include "main.h"
+
 struct sk_buff;
 struct work_struct;