Message ID | 20160706024929.GA25250@lkp-nex05 (mailing list archive) |
---|---|
State | Accepted, archived |
Commit | 36e731685be1c754612d57d1b375623147544492 |
Delegated to: | Marek Lindner |
Headers |
Return-Path: <b.a.t.m.a.n-bounces@lists.open-mesh.org> X-Original-To: patchwork@open-mesh.org Delivered-To: patchwork@open-mesh.org Received: from open-mesh.org (localhost [IPv6:::1]) by open-mesh.org (Postfix) with ESMTP id 7F85280640; Wed, 6 Jul 2016 07:12:19 +0200 (CEST) Authentication-Results: open-mesh.org; dmarc=none header.from=intel.com Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.88; helo=mga01.intel.com; envelope-from=fengguang.wu@intel.com; receiver=b.a.t.m.a.n@lists.open-mesh.org Authentication-Results: open-mesh.org; dmarc=none header.from=intel.com X-Greylist: delayed 587 seconds by postgrey-1.35 at open-mesh.org; Wed, 06 Jul 2016 05:00:21 CEST Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by open-mesh.org (Postfix) with ESMTP id 0BA5E8054F for <b.a.t.m.a.n@lists.open-mesh.org>; Wed, 6 Jul 2016 05:00:20 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP; 05 Jul 2016 19:50:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos; i="5.28,317,1464678000"; d="scan'208"; a="1001577918" Received: from bee.sh.intel.com (HELO bee) ([10.239.97.14]) by fmsmga001.fm.intel.com with ESMTP; 05 Jul 2016 19:50:31 -0700 Received: from kbuild by bee with local (Exim 4.83) (envelope-from <fengguang.wu@intel.com>) id 1bKcuq-000HW5-Ig; Wed, 06 Jul 2016 10:50:20 +0800 Date: Wed, 6 Jul 2016 10:49:29 +0800 From: kbuild test robot <fengguang.wu@intel.com> Message-ID: <20160706024929.GA25250@lkp-nex05> References: <201607061025.fb3YfL1g%fengguang.wu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201607061025.fb3YfL1g%fengguang.wu@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: <locally generated> X-SA-Exim-Mail-From: fengguang.wu@intel.com X-SA-Exim-Scanned: No (on bee); SAEximRunCond expanded to false X-Mailman-Approved-At: Wed, 06 Jul 2016 07:12:17 +0200 Cc: Marek Lindner <mareklindner@neomailbox.ch>, netdev@vger.kernel.org, b.a.t.m.a.n@lists.open-mesh.org, Antonio Quartulli <a@unstable.cc>, linux-kernel@vger.kernel.org, kbuild-all@01.org Subject: [B.A.T.M.A.N.] [PATCH] batman-adv: fix boolreturn.cocci warnings X-BeenThere: b.a.t.m.a.n@lists.open-mesh.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: The list for a Better Approach To Mobile Ad-hoc Networking <b.a.t.m.a.n.lists.open-mesh.org> List-Unsubscribe: <https://lists.open-mesh.org/mm/options/b.a.t.m.a.n>, <mailto:b.a.t.m.a.n-request@lists.open-mesh.org?subject=unsubscribe> List-Archive: <http://lists.open-mesh.org/pipermail/b.a.t.m.a.n/> List-Post: <mailto:b.a.t.m.a.n@lists.open-mesh.org> List-Help: <mailto:b.a.t.m.a.n-request@lists.open-mesh.org?subject=help> List-Subscribe: <https://lists.open-mesh.org/mm/listinfo/b.a.t.m.a.n>, <mailto:b.a.t.m.a.n-request@lists.open-mesh.org?subject=subscribe> Reply-To: The list for a Better Approach To Mobile Ad-hoc Networking <b.a.t.m.a.n@lists.open-mesh.org> Errors-To: b.a.t.m.a.n-bounces@lists.open-mesh.org Sender: "B.A.T.M.A.N" <b.a.t.m.a.n-bounces@lists.open-mesh.org> |
Commit Message
kbuild test robot
July 6, 2016, 2:49 a.m. UTC
net/batman-adv/bridge_loop_avoidance.c:1105:9-10: WARNING: return of 0/1 in function 'batadv_bla_process_claim' with return type bool
Return statements in functions returning bool should use
true/false instead of 1/0.
Generated by: scripts/coccinelle/misc/boolreturn.cocci
CC: Sven Eckelmann <sven@narfation.org>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
bridge_loop_avoidance.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On Wednesday 06 July 2016 10:49:29 kbuild test robot wrote: > net/batman-adv/bridge_loop_avoidance.c:1105:9-10: WARNING: return of 0/1 in function 'batadv_bla_process_claim' with return type bool > > Return statements in functions returning bool should use > true/false instead of 1/0. > Generated by: scripts/coccinelle/misc/boolreturn.cocci > > CC: Sven Eckelmann <sven@narfation.org> > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> > --- Reviewed-by: Sven Eckelmann <sven@narfation.org> The problematic commit is in batman-adv.git (next): Fixes: a998bf5dfbd7 ("batman-adv: add detection for complex bridge loops") And in net-next.git (due to some reordering) Fixes: 4b426b108ac8 ("batman-adv: Use bool as return type for boolean functions") Thanks, Sven > > bridge_loop_avoidance.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- a/net/batman-adv/bridge_loop_avoidance.c > +++ b/net/batman-adv/bridge_loop_avoidance.c > @@ -1102,7 +1102,7 @@ static bool batadv_bla_process_claim(str > > /* Let the loopdetect frames on the mesh in any case. */ > if (bla_dst->type == BATADV_CLAIM_TYPE_LOOPDETECT) > - return 0; > + return false; > > /* check if it is a claim frame. */ > ret = batadv_check_claim_group(bat_priv, primary_if, hw_src, hw_dst,
On Wednesday 06 July 2016 08:12:09 Sven Eckelmann wrote: > On Wednesday 06 July 2016 10:49:29 kbuild test robot wrote: > > net/batman-adv/bridge_loop_avoidance.c:1105:9-10: WARNING: return of 0/1 in function 'batadv_bla_process_claim' with return type bool > > > > Return statements in functions returning bool should use > > true/false instead of 1/0. > > Generated by: scripts/coccinelle/misc/boolreturn.cocci > > > > CC: Sven Eckelmann <sven@narfation.org> > > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> > > --- > > Reviewed-by: Sven Eckelmann <sven@narfation.org> > > The problematic commit is in batman-adv.git (next): > > Fixes: a998bf5dfbd7 ("batman-adv: add detection for complex bridge loops") Sorry, I meant maint and not next. It was already part of v2016.2 @Marek not sure where you want to apply it. It should have no effect on the actual functionality. Kind regards, Sven
On Wednesday, July 06, 2016 10:49:29 kbuild test robot wrote: > net/batman-adv/bridge_loop_avoidance.c:1105:9-10: WARNING: return of 0/1 in > function 'batadv_bla_process_claim' with return type bool > > Return statements in functions returning bool should use > true/false instead of 1/0. > Generated by: scripts/coccinelle/misc/boolreturn.cocci > > CC: Sven Eckelmann <sven@narfation.org> > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> > --- > > bridge_loop_avoidance.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied in revision 36e7316. Thanks, Marek
--- a/net/batman-adv/bridge_loop_avoidance.c +++ b/net/batman-adv/bridge_loop_avoidance.c @@ -1102,7 +1102,7 @@ static bool batadv_bla_process_claim(str /* Let the loopdetect frames on the mesh in any case. */ if (bla_dst->type == BATADV_CLAIM_TYPE_LOOPDETECT) - return 0; + return false; /* check if it is a claim frame. */ ret = batadv_check_claim_group(bat_priv, primary_if, hw_src, hw_dst,