diff mbox

alfred: vis: Fix netlink function fallback

Message ID 20160922214607.22123-1-sven@narfation.org (mailing list archive)
State Accepted, archived
Commit 2208996ac1c442556c1f8de67a48f0782fbf7e1b
Delegated to: Simon Wunderlich
Headers

Commit Message

Sven Eckelmann Sept. 22, 2016, 9:46 p.m. UTC 
  The netlink functions return -EOPNOTSUPP when the kernel doesn't support
the netlink command. The caller can then fall back to debugfs. So check for
-EOPNOTSUPP and not EOPNOTSUPP.

Fixes: bca55a86fecd ("alfred: vis: Add support for netlink")
Signed-off-by: Sven Eckelmann <sven@narfation.org>
---
 vis/vis.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Simon Wunderlich Oct. 14, 2016, 1:33 p.m. UTC | #1 
On Thursday, September 22, 2016 11:46:07 PM CEST Sven Eckelmann wrote:
> The netlink functions return -EOPNOTSUPP when the kernel doesn't support
> the netlink command. The caller can then fall back to debugfs. So check for
> -EOPNOTSUPP and not EOPNOTSUPP.
> 
> Fixes: bca55a86fecd ("alfred: vis: Add support for netlink")
> Signed-off-by: Sven Eckelmann <sven@narfation.org>

Applied in revision 2208996.

Thanks!
     Simon
diff mbox

Patch

diff --git a/vis/vis.c b/vis/vis.c
index b865508..677f8aa 100644
--- a/vis/vis.c
+++ b/vis/vis.c
@@ -361,7 +361,7 @@  static int parse_transtable_local(struct globals *globals)
 	int ret;
 
 	ret = parse_transtable_local_netlink(globals);
-	if (ret != EOPNOTSUPP)
+	if (ret != -EOPNOTSUPP)
 		return ret;
 
 	return parse_transtable_local_debugfs(globals);
@@ -602,7 +602,7 @@  static int parse_orig_list(struct globals *globals)
 	int ret;
 
 	ret = parse_orig_list_netlink(globals);
-	if (ret != EOPNOTSUPP)
+	if (ret != -EOPNOTSUPP)
 		return ret;
 
 	return parse_orig_list_debugfs(globals);