From patchwork Mon Oct 31 07:36:27 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sven Eckelmann X-Patchwork-Id: 16789 X-Patchwork-Delegate: sw@simonwunderlich.de Return-Path: X-Original-To: patchwork@open-mesh.org Delivered-To: patchwork@open-mesh.org Received: from open-mesh.org (localhost [IPv6:::1]) by open-mesh.org (Postfix) with ESMTP id 9F9D583185; Mon, 31 Oct 2016 08:37:13 +0100 (CET) Authentication-Results: open-mesh.org; dmarc=none header.from=narfation.org Authentication-Results: open-mesh.org; dkim=fail reason="verification failed; unprotected key" header.d=narfation.org header.i=@narfation.org header.b=gPq9Sf5k; dkim-adsp=fail (unprotected policy); dkim-atps=neutral Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2001:4d88:2000:7::2; helo=v3-1039.vlinux.de; envelope-from=sven@narfation.org; receiver=b.a.t.m.a.n@lists.open-mesh.org Authentication-Results: open-mesh.org; dmarc=pass header.from=narfation.org Received: from v3-1039.vlinux.de (narfation.org [IPv6:2001:4d88:2000:7::2]) by open-mesh.org (Postfix) with ESMTPS id EAD5D818B8 for ; Mon, 31 Oct 2016 08:36:52 +0100 (CET) Received: from sven-desktop.home.narfation.org (p200300C593C2C3F9E217CA8766CEE734.dip0.t-ipconnect.de [IPv6:2003:c5:93c2:c3f9:e217:ca87:66ce:e734]) by v3-1039.vlinux.de (Postfix) with ESMTPSA id 72B501100A9; Mon, 31 Oct 2016 08:36:52 +0100 (CET) Authentication-Results: v3-1039.vlinux.de; dmarc=none header.from=narfation.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=narfation.org; s=20121; t=1477899412; bh=L/Cd7pmaOo3iKhkT8LklbguiRIfX8Y6E7LUZ/lu2gZA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gPq9Sf5kBlCXwOCtCXm9SCn0hK3eEsQy2IdTppA6ILL6hgZHUA98RjTeUXrWqcKLm Cyj8UkiVMmgAn+GdeqSVAXCrcKw9o+eiMfCkOIVvcBk6YB7mmNs+9xhDtNxQYDYnfY mXs7+RKUfw9ib/XAW65sPRkMi5ht1l3DqqRO4McM= From: Sven Eckelmann To: b.a.t.m.a.n@lists.open-mesh.org Date: Mon, 31 Oct 2016 08:36:27 +0100 Message-Id: <20161031073629.31819-4-sven@narfation.org> X-Mailer: git-send-email 2.10.1 In-Reply-To: <1637163.TC9CcXIrIP@sven-edge> References: <1637163.TC9CcXIrIP@sven-edge> Subject: [B.A.T.M.A.N.] [PATCH 4/6] batman-adv: Revert "compat: Move netlink const compat to coccinelle" X-BeenThere: b.a.t.m.a.n@lists.open-mesh.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: The list for a Better Approach To Mobile Ad-hoc Networking List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: The list for a Better Approach To Mobile Ad-hoc Networking Errors-To: b.a.t.m.a.n-bounces@lists.open-mesh.org Sender: "B.A.T.M.A.N" The coccinelle in Debian Jessie seems to be broken. It fails to parse the patches and thus makes it impossible to use the out-of-tree module in these systems. Therefore drop it for now. This reverts commit 2f9f52d1dfc417201028cc65f91aaddc5eaf493a. Signed-off-by: Sven Eckelmann --- Makefile | 3 ++- compat-patches/0002-genl-const.INFO | 15 --------------- compat-patches/0002-genl-const.cocci | 10 ---------- compat-patches/replacements.sh | 9 +++++++++ 4 files changed, 11 insertions(+), 26 deletions(-) delete mode 100644 compat-patches/0002-genl-const.INFO delete mode 100644 compat-patches/0002-genl-const.cocci create mode 100755 compat-patches/replacements.sh diff --git a/Makefile b/Makefile index e9c499f..67f1988 100644 --- a/Makefile +++ b/Makefile @@ -108,7 +108,7 @@ install: config $(SOURCE_STAMP) config: $(PWD)/gen-compat-autoconf.sh $(PWD)/compat-autoconf.h -$(SOURCE_STAMP): $(SOURCE) compat-patches/* +$(SOURCE_STAMP): $(SOURCE) compat-patches/* compat-patches/replacements.sh $(MKDIR) $(BUILD_DIR)/net/batman-adv/ @$(LN) ../Makefile $(BUILD_DIR)/Makefile @$(RM) $(SOURCE_BUILD) @@ -126,6 +126,7 @@ $(SOURCE_STAMP): $(SOURCE) compat-patches/* $(SPATCH) $(SPATCH_FLAGS) --dir $(BUILD_DIR) --sp-file compat-patches/$${i} > /dev/null; \ fi; \ done + compat-patches/replacements.sh touch $(SOURCE_STAMP) .PHONY: all clean install config diff --git a/compat-patches/0002-genl-const.INFO b/compat-patches/0002-genl-const.INFO deleted file mode 100644 index 192c5c6..0000000 --- a/compat-patches/0002-genl-const.INFO +++ /dev/null @@ -1,15 +0,0 @@ -Newer kernels make generic netlink ops and multicast groups -const, but older can't have that. We therefore introduce -__genl_const, which can be defined depending on the kernel. - -What kernel versions require this? - -XXX: try to SmPLify - -The struct genl_ops gave the *option* to make it const via: -mcgrof@ergon ~/linux (git::master)$ git describe --contains f84f771d9 -v3.13-rc1~33^2~32^2~2 - -The struct genl_multicast_group was *forced* to be const via: -mcgrof@ergon ~/linux (git::master)$ git describe --contains 2a94fe48f -v3.13-rc1~33^2^2 diff --git a/compat-patches/0002-genl-const.cocci b/compat-patches/0002-genl-const.cocci deleted file mode 100644 index 36c71d6..0000000 --- a/compat-patches/0002-genl-const.cocci +++ /dev/null @@ -1,10 +0,0 @@ -@@ -attribute __genl_const; -@@ -( --const struct genl_multicast_group -+__genl_const struct genl_multicast_group -| --const struct genl_ops -+__genl_const struct genl_ops -) diff --git a/compat-patches/replacements.sh b/compat-patches/replacements.sh new file mode 100755 index 0000000..7dcb953 --- /dev/null +++ b/compat-patches/replacements.sh @@ -0,0 +1,9 @@ +#! /bin/sh + +set -e + +# for kernel < 3.13 to make netlink compat code work +sed -i \ + -e 's/^static const struct genl_multicast_group batadv_netlink_mcgrps/static __genl_const struct genl_multicast_group batadv_netlink_mcgrps/' \ + -e 's/^static const struct genl_ops batadv_netlink_ops/static __genl_const struct genl_ops batadv_netlink_ops/' \ + build/net/batman-adv/netlink.c