diff mbox

batman-adv: fix memory leak when dropping packet from other gateway

Message ID 20170519080142.21070-1-sven@narfation.org (mailing list archive)
State Accepted, archived
Commit a58feb79ed1447e3e83f3b0b1a23779886869f39
Delegated to: Simon Wunderlich
Headers

Commit Message

Sven Eckelmann May 19, 2017, 8:01 a.m. UTC 
  From: Andreas Pape <apape@phoenixcontact.com>

This patch fixes a memory leak introduced with commit "batman-adv:
drop unicast packets from other backbone gw".

Fixes: bfe2a1971f43 ("batman-adv: drop unicast packets from other backbone gw")
Signed-off-by: Andreas Pape <apape@phoenixcontact.com>
---
 net/batman-adv/routing.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Comments

Sven Eckelmann May 19, 2017, 10:40 a.m. UTC | #1 
On Freitag, 19. Mai 2017 10:01:42 CEST Sven Eckelmann wrote:
> From: Andreas Pape <apape@phoenixcontact.com>
> 
> This patch fixes a memory leak introduced with commit "batman-adv:
> drop unicast packets from other backbone gw".
> 
> Fixes: bfe2a1971f43 ("batman-adv: drop unicast packets from other backbone gw")
> Signed-off-by: Andreas Pape <apape@phoenixcontact.com>
> ---
>  net/batman-adv/routing.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

Patch applied as a58feb79ed1447e3e83f3b0b1a23779886869f39 [1]

Thanks,
	Sven

[1] https://git.open-mesh.org/batman-adv.git/commit/a58feb79ed1447e3e83f3b0b1a23779886869f39
diff mbox

Patch

diff --git a/net/batman-adv/routing.c b/net/batman-adv/routing.c
index e1ebe14..ae9f4d3 100644
--- a/net/batman-adv/routing.c
+++ b/net/batman-adv/routing.c
@@ -987,7 +987,7 @@  int batadv_recv_unicast_packet(struct sk_buff *skb,
 				batadv_dbg(BATADV_DBG_BLA, bat_priv,
 					   "recv_unicast_packet(): Dropped unicast pkt received from another backbone gw %pM.\n",
 					   orig_addr_gw);
-				return NET_RX_DROP;
+				goto free_skb;
 			}
 		}