[00/10] batctl: Fixes and minor cleanup
Message ID | 20171123140444.17119-1-sven.eckelmann@openmesh.com (mailing list archive) |
---|---|
Headers |
Return-Path: <b.a.t.m.a.n-bounces@lists.open-mesh.org> X-Original-To: patchwork@open-mesh.org Delivered-To: patchwork@open-mesh.org Received: from open-mesh.org (localhost [IPv6:::1]) by open-mesh.org (Postfix) with ESMTP id 8B5D580588; Thu, 23 Nov 2017 15:05:04 +0100 (CET) Authentication-Results: open-mesh.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=openmesh-com.20150623.gappssmtp.com header.i=@openmesh-com.20150623.gappssmtp.com header.b="qPixyLVA"; dkim-atps=neutral Received-SPF: None (mailfrom) identity=mailfrom; client-ip=2607:f8b0:400d:c09::22e; helo=mail-qk0-x22e.google.com; envelope-from=sven.eckelmann@openmesh.com; receiver=<UNKNOWN> Received: from mail-qk0-x22e.google.com (mail-qk0-x22e.google.com [IPv6:2607:f8b0:400d:c09::22e]) by open-mesh.org (Postfix) with ESMTPS id 4BCDC803A6 for <b.a.t.m.a.n@lists.open-mesh.org>; Thu, 23 Nov 2017 15:05:01 +0100 (CET) Received: by mail-qk0-x22e.google.com with SMTP id a194so21088167qkc.9 for <b.a.t.m.a.n@lists.open-mesh.org>; Thu, 23 Nov 2017 06:05:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openmesh-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=LT+RhzNN/+6Tw4bBiA1ukTAXzx3Q4GBc/bNTCGi5mQI=; b=qPixyLVAPvr8E7M5CQdy4Y+nzlDnzSyAuBKzuxvYOnovS+UTM8iq5EG1QBEeDUCI1z IXJsd6h9Y3kV2sRuq1Qcl/9Etwci2mGfS95ztqDLCgCG8v51tqIQvym42u0/3f28tL6P xKB0L845jFrXyKBVkI+52SRnZHNf4j2oeWUYqa1v5FlVBcLjJBmkNczn4NUAC9Pn9U0E zaBm11NsKPo9omiUnOFtncZ91ElK8RnX7U5PUSQ7jg9FDEa26PglbwhM+G8Qg2cWQ901 pSD1NtgEBTMmHPW0P7uIx6J9JpgqwwUcJNnrfCJggDSa2FTp9lORAN4UOlQ4jSLyGBAU 46Mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=LT+RhzNN/+6Tw4bBiA1ukTAXzx3Q4GBc/bNTCGi5mQI=; b=leMe7RVd4Bae5d8dRVqO2g8jvfHR38Ka2ji+HaLYY/yjrphKiD8XB0z5ct4Ot/77cJ 917MSB7lXTbroxuQmi9xRYZWKLHZ/tLdEQ0ea3Jkl1kjjWBTfL+E2x7iERyWQn/KPbAD fMQE5hT9IljOmG6N1W8NPTHM99/y739v9f946hmZQYSQM9ZMB/sS9t+bvCjy+AnV7YV1 i92NEoeF1rBwNWJXfnl76t2voSErbDHJ7I5mKh1mbytSPmEngVxnuRvi3MESO20Lv5yj T9Lkd2R97ZuREK1gFqrqeLggb7Yw3ATuUBgipgXLZ4wTqvH4m+NeYuyLerEbyxPW11KN fGPQ== X-Gm-Message-State: AJaThX4CAbqk6ymcg/Z2STFqcT32BuSspM0FGNL5ce90hf42YFsnCaQq kTVLew1nn7I+7Ok+5s4lyfucniLl X-Google-Smtp-Source: AGs4zMZJ0HtM9k50xxae851++qLciZy76tqW0qWO9RWCil8cFpLHZc1yP4Wb/Kzv2FRwjr9vZpnheA== X-Received: by 10.55.189.2 with SMTP id n2mr6431760qkf.36.1511445900035; Thu, 23 Nov 2017 06:05:00 -0800 (PST) Received: from sven-desktop.home.narfation.org (p2003007C6F53F7FA6FAE965552C91071.dip0.t-ipconnect.de. [2003:7c:6f53:f7fa:6fae:9655:52c9:1071]) by smtp.gmail.com with ESMTPSA id c50sm6747076qte.38.2017.11.23.06.04.58 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 23 Nov 2017 06:04:59 -0800 (PST) From: Sven Eckelmann <sven.eckelmann@openmesh.com> To: b.a.t.m.a.n@lists.open-mesh.org Date: Thu, 23 Nov 2017 15:04:34 +0100 Message-Id: <20171123140444.17119-1-sven.eckelmann@openmesh.com> X-Mailer: git-send-email 2.11.0 Subject: [B.A.T.M.A.N.] [PATCH 00/10] batctl: Fixes and minor cleanup X-BeenThere: b.a.t.m.a.n@lists.open-mesh.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The list for a Better Approach To Mobile Ad-hoc Networking <b.a.t.m.a.n.lists.open-mesh.org> List-Unsubscribe: <https://lists.open-mesh.org/mm/options/b.a.t.m.a.n>, <mailto:b.a.t.m.a.n-request@lists.open-mesh.org?subject=unsubscribe> List-Archive: <http://lists.open-mesh.org/pipermail/b.a.t.m.a.n/> List-Post: <mailto:b.a.t.m.a.n@lists.open-mesh.org> List-Help: <mailto:b.a.t.m.a.n-request@lists.open-mesh.org?subject=help> List-Subscribe: <https://lists.open-mesh.org/mm/listinfo/b.a.t.m.a.n>, <mailto:b.a.t.m.a.n-request@lists.open-mesh.org?subject=subscribe> Reply-To: The list for a Better Approach To Mobile Ad-hoc Networking <b.a.t.m.a.n@lists.open-mesh.org> Errors-To: b.a.t.m.a.n-bounces@lists.open-mesh.org Sender: "B.A.T.M.A.N" <b.a.t.m.a.n-bounces@lists.open-mesh.org> |
Message
Sven Eckelmann
Nov. 23, 2017, 2:04 p.m. UTC
From: Sven Eckelmann <sven@narfation.org>
Hi,
today I had the unpleasent experience to receive [1] to a lot of PDF files
which seem to contain some reports of the Klocwork static code analysis tool.
Most of the stuff was nonsense about memory/resource leaks (even when it
stored in some kind of structure one line before). I gathered the only
interesting portions and prepared some patches for them.
The last two patches are actually not really bug fixes but are about code
which completely killed the static analyzer. I didn't like the code in
the last patch (looked to complex for something relatively easy) and thus
I've just replaced it.
WARNING: these things were only compile tested
Kind regards,
Sven
[1] not unpleasent due to some issue reports. But going through several
hundred false positives wasn't my goal for today. Someone at seems to
get paid by false-positives which this Klocworks analyzer produces
(and there are really some braindead ones - even clang's static analyzer
looks like a genius against some of these reports)
Sven Eckelmann (10):
batctl: Print dummy value when localtime failed
batctl: Handle failure during hash_iterator allocation
batctl: Handle allocation error for path_buff
batctl: Handle nlmsg_alloc errors
batctl: Handle nl_socket_alloc errors
batctl: Handle nl_cb_alloc errors
batctl: Free nl_sock on genl_ctrl_resolve error
batctl: Free nl_sock when if_nametoindex failed
batctl: tcpdump: Fix types for for TT v1
batctl: Simplify concatenation of pathnames
bat-hosts.c | 4 +---
functions.c | 8 ++------
hash.c | 3 +++
netlink.c | 63 +++++++++++++++++++++++++++++++++++++++++++++++++++++--------
sys.c | 15 +++++++++++++++
tcpdump.c | 9 +++++++--
6 files changed, 83 insertions(+), 19 deletions(-)