diff mbox series

batctl: netlink: fix resetting mcast_flags_priv to unsupported state

Message ID 20180320011924.28287-1-linus.luessing@c0d3.blue
State Accepted, archived
Commit 15f6d908fe3d152fc7a4c682231d13fbf1b8751e
Delegated to: Simon Wunderlich
Headers show
Series batctl: netlink: fix resetting mcast_flags_priv to unsupported state | expand

Commit Message

Linus Lüssing March 20, 2018, 1:19 a.m. UTC 
This fixes a copy & paste error detected by Coverity.

Fixes: b56061058113 ("batctl: add netlink dump function for multicast flags table")
Reported-by: scan-admin@coverity.com
Signed-off-by: Linus Lüssing <linus.luessing@c0d3.blue>
---
 netlink.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Sven Eckelmann March 20, 2018, 7:11 a.m. UTC | #1 
On Dienstag, 20. März 2018 02:19:24 CET Linus Lüssing wrote:
> This fixes a copy & paste error detected by Coverity.
> 
> Fixes: b56061058113 ("batctl: add netlink dump function for multicast flags table")
> Reported-by: scan-admin@coverity.com
> Signed-off-by: Linus Lüssing <linus.luessing@c0d3.blue>
> ---
>  netlink.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied as 15f6d90 [1].

Thanks,
	Sven

[1] https://git.open-mesh.org/batctl.git/commit/15f6d908fe3d152fc7a4c682231d13fbf1b8751e
diff mbox series

Patch

diff --git a/netlink.c b/netlink.c
index ab7be1e..f0fd1d9 100644
--- a/netlink.c
+++ b/netlink.c
@@ -252,7 +252,7 @@  static int info_callback(struct nl_msg *msg, void *arg)
 		if (attrs[BATADV_ATTR_MCAST_FLAGS_PRIV])
 			mcast_flags_priv = nla_get_u32(attrs[BATADV_ATTR_MCAST_FLAGS_PRIV]);
 		else
-			mcast_flags = -EOPNOTSUPP;
+			mcast_flags_priv = -EOPNOTSUPP;
 
 		switch (opts->nl_cmd) {
 		case BATADV_CMD_GET_TRANSTABLE_LOCAL: