batman-adv: fix argument name in kernel-doc

Message ID 20180510152946.7802-1-a@unstable.cc (mailing list archive)
State Rejected, archived
Delegated to: Simon Wunderlich
Headers
Series batman-adv: fix argument name in kernel-doc |

Commit Message

Antonio Quartulli May 10, 2018, 3:29 p.m. UTC
  Signed-off-by: Antonio Quartulli <a@unstable.cc>
---
 net/batman-adv/tp_meter.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Sven Eckelmann May 10, 2018, 3:33 p.m. UTC | #1
On Donnerstag, 10. Mai 2018 17:29:46 CEST Antonio Quartulli wrote:
> Signed-off-by: Antonio Quartulli <a@unstable.cc>
> ---
>  net/batman-adv/tp_meter.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/batman-adv/tp_meter.c b/net/batman-adv/tp_meter.c
> index 11520de9..55d8e4c1 100644
> --- a/net/batman-adv/tp_meter.c
> +++ b/net/batman-adv/tp_meter.c
> @@ -808,7 +808,7 @@ static int batadv_tp_wait_available(struct batadv_tp_vars *tp_vars, size_t plen)
>  
>  /**
>   * batadv_tp_send() - main sending thread of a tp meter session
> - * @arg: address of the related tp_vars
> + * @work: address of the related tp_vars
>   *
>   * Return: nothing, this function never returns
>   */
> 

Just checked the master branch and the argument is still called arg there:

    /**
     * batadv_tp_send() - main sending thread of a tp meter session
     * @arg: address of the related tp_vars
     *
     * Return: nothing, this function never returns
     */
    static int batadv_tp_send(void *arg)
    {

So I will reject this patch.

Kind regards,
	Sven
  
Antonio Quartulli May 10, 2018, 3:35 p.m. UTC | #2
On 10/05/18 23:33, Sven Eckelmann wrote:
> On Donnerstag, 10. Mai 2018 17:29:46 CEST Antonio Quartulli wrote:
>> Signed-off-by: Antonio Quartulli <a@unstable.cc>
>> ---
>>  net/batman-adv/tp_meter.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/net/batman-adv/tp_meter.c b/net/batman-adv/tp_meter.c
>> index 11520de9..55d8e4c1 100644
>> --- a/net/batman-adv/tp_meter.c
>> +++ b/net/batman-adv/tp_meter.c
>> @@ -808,7 +808,7 @@ static int batadv_tp_wait_available(struct batadv_tp_vars *tp_vars, size_t plen)
>>  
>>  /**
>>   * batadv_tp_send() - main sending thread of a tp meter session
>> - * @arg: address of the related tp_vars
>> + * @work: address of the related tp_vars
>>   *
>>   * Return: nothing, this function never returns
>>   */
>>
> 
> Just checked the master branch and the argument is still called arg there:
> 
>     /**
>      * batadv_tp_send() - main sending thread of a tp meter session
>      * @arg: address of the related tp_vars
>      *
>      * Return: nothing, this function never returns
>      */
>     static int batadv_tp_send(void *arg)
>     {
> 
> So I will reject this patch.

Agreed and sorry for the mistake. This must be coming from another new
branch we are currently working on.

Cheers,
  

Patch

diff --git a/net/batman-adv/tp_meter.c b/net/batman-adv/tp_meter.c
index 11520de9..55d8e4c1 100644
--- a/net/batman-adv/tp_meter.c
+++ b/net/batman-adv/tp_meter.c
@@ -808,7 +808,7 @@  static int batadv_tp_wait_available(struct batadv_tp_vars *tp_vars, size_t plen)
 
 /**
  * batadv_tp_send() - main sending thread of a tp meter session
- * @arg: address of the related tp_vars
+ * @work: address of the related tp_vars
  *
  * Return: nothing, this function never returns
  */