| Message ID | 20180524120300.15829-3-sw@simonwunderlich.de (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | Simon Wunderlich |
| Headers |
Return-Path: <b.a.t.m.a.n-bounces@lists.open-mesh.org> X-Original-To: patchwork@open-mesh.org Delivered-To: patchwork@open-mesh.org Received: from open-mesh.org (localhost [IPv6:::1]) by open-mesh.org (Postfix) with ESMTP id BDAD2826C8; Thu, 24 May 2018 15:59:09 +0200 (CEST) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2001:4d88:2000:24::c0de; helo=mail.mail.packetmixer.de; envelope-from=sw@simonwunderlich.de; receiver=<UNKNOWN> Received: from mail.mail.packetmixer.de (packetmixer.de [IPv6:2001:4d88:2000:24::c0de]) by open-mesh.org (Postfix) with ESMTPS id E17A780604 for <b.a.t.m.a.n@lists.open-mesh.org>; Thu, 24 May 2018 14:03:03 +0200 (CEST) Received: from kero.packetmixer.de (p200300C593E5F600A0617AF7D322DA00.dip0.t-ipconnect.de [IPv6:2003:c5:93e5:f600:a061:7af7:d322:da00]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mail.packetmixer.de (Postfix) with ESMTPSA id 8FE7762055; Thu, 24 May 2018 14:03:03 +0200 (CEST) From: Simon Wunderlich <sw@simonwunderlich.de> To: davem@davemloft.net Date: Thu, 24 May 2018 14:02:54 +0200 Message-Id: <20180524120300.15829-3-sw@simonwunderlich.de> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180524120300.15829-1-sw@simonwunderlich.de> References: <20180524120300.15829-1-sw@simonwunderlich.de> Subject: [B.A.T.M.A.N.] [PATCH 2/8] batman-adv: Disable CONFIG_BATMAN_ADV_DEBUGFS by default X-BeenThere: b.a.t.m.a.n@lists.open-mesh.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The list for a Better Approach To Mobile Ad-hoc Networking <b.a.t.m.a.n.lists.open-mesh.org> List-Unsubscribe: <https://lists.open-mesh.org/mm/options/b.a.t.m.a.n>, <mailto:b.a.t.m.a.n-request@lists.open-mesh.org?subject=unsubscribe> List-Archive: <http://lists.open-mesh.org/pipermail/b.a.t.m.a.n/> List-Post: <mailto:b.a.t.m.a.n@lists.open-mesh.org> List-Help: <mailto:b.a.t.m.a.n-request@lists.open-mesh.org?subject=help> List-Subscribe: <https://lists.open-mesh.org/mm/listinfo/b.a.t.m.a.n>, <mailto:b.a.t.m.a.n-request@lists.open-mesh.org?subject=subscribe> Reply-To: The list for a Better Approach To Mobile Ad-hoc Networking <b.a.t.m.a.n@lists.open-mesh.org> Cc: netdev@vger.kernel.org, b.a.t.m.a.n@lists.open-mesh.org Errors-To: b.a.t.m.a.n-bounces@lists.open-mesh.org Sender: "B.A.T.M.A.N" <b.a.t.m.a.n-bounces@lists.open-mesh.org> |
| Series |
[1/8] batman-adv: Start new development cycle
|
|
Commit Message
Simon Wunderlich
May 24, 2018, 12:02 p.m. UTC
From: Sven Eckelmann <sven@narfation.org> All tools which were known to the batman-adv development team are supporting the batman-adv netlink interface since a while. Also debugfs is not supported for batman-adv interfaces in any non-default netns. Thus disabling CONFIG_BATMAN_ADV_DEBUGFS by default should not cause problems on most systems. It is still possible to enable it in case it is still required in a specific setup. Signed-off-by: Sven Eckelmann <sven@narfation.org> Signed-off-by: Simon Wunderlich <sw@simonwunderlich.de> --- net/batman-adv/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Comments
Hello! On 5/24/2018 3:02 PM, Simon Wunderlich wrote: > From: Sven Eckelmann <sven@narfation.org> > > All tools which were known to the batman-adv development team are > supporting the batman-adv netlink interface since a while. Also debugfs is > not supported for batman-adv interfaces in any non-default netns. Thus > disabling CONFIG_BATMAN_ADV_DEBUGFS by default should not cause problems on > most systems. It is still possible to enable it in case it is still > required in a specific setup. > > Signed-off-by: Sven Eckelmann <sven@narfation.org> > Signed-off-by: Simon Wunderlich <sw@simonwunderlich.de> > --- > net/batman-adv/Kconfig | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/net/batman-adv/Kconfig b/net/batman-adv/Kconfig > index e4e2e02b7380..bee034a95208 100644 > --- a/net/batman-adv/Kconfig > +++ b/net/batman-adv/Kconfig > @@ -94,13 +94,13 @@ config BATMAN_ADV_DEBUGFS > bool "batman-adv debugfs entries" > depends on BATMAN_ADV > depends on DEBUG_FS > - default y > + default n N is the default default. :-) You don't need this line. [...] MBR, Sergei
On Freitag, 25. Mai 2018 13:33:59 CEST Sergei Shtylyov wrote: [...] > > --- a/net/batman-adv/Kconfig > > +++ b/net/batman-adv/Kconfig > > @@ -94,13 +94,13 @@ config BATMAN_ADV_DEBUGFS > > bool "batman-adv debugfs entries" > > depends on BATMAN_ADV > > depends on DEBUG_FS > > - default y > > + default n > > N is the default default. :-) You don't need this line. Hm, looks like this would have to be changed in a lot of places (~782 according to `git grep 'default n$'|wc -l` in my slightly outdated linux- next). Do you want to fix it everywhere? Might be good to get this integrated in checkpatch.pl when this will become a new policy. Kind regards, Sven
On 5/25/2018 1:50 PM, Sven Eckelmann wrote: > [...] >>> --- a/net/batman-adv/Kconfig >>> +++ b/net/batman-adv/Kconfig >>> @@ -94,13 +94,13 @@ config BATMAN_ADV_DEBUGFS >>> bool "batman-adv debugfs entries" >>> depends on BATMAN_ADV >>> depends on DEBUG_FS >>> - default y >>> + default n >> >> N is the default default. :-) You don't need this line. > > Hm, looks like this would have to be changed in a lot of places (~782 > according to `git grep 'default n$'|wc -l` in my slightly outdated linux- > next). Do you want to fix it everywhere? No, but we can at least not add the new ones... > Might be good to get this integrated > in checkpatch.pl when this will become a new policy. Adding Joe Perches. Joe, can you add a check for "default n"? > Kind regards, > Sven MBR, Sergei
On Freitag, 25. Mai 2018 14:13:40 CEST Sergei Shtylyov wrote: > > [...] > >>> --- a/net/batman-adv/Kconfig > >>> +++ b/net/batman-adv/Kconfig > >>> @@ -94,13 +94,13 @@ config BATMAN_ADV_DEBUGFS > >>> bool "batman-adv debugfs entries" > >>> depends on BATMAN_ADV > >>> depends on DEBUG_FS > >>> - default y > >>> + default n > >> > >> N is the default default. :-) You don't need this line. > > > > Hm, looks like this would have to be changed in a lot of places (~782 > > according to `git grep 'default n$'|wc -l` in my slightly outdated linux- > > next). Do you want to fix it everywhere? > > No, but we can at least not add the new ones... But the patch was added to net-next yesterday. Kind regards, Sven
On 05/25/2018 02:15 PM, Sven Eckelmann wrote: >>> [...] >>>>> --- a/net/batman-adv/Kconfig >>>>> +++ b/net/batman-adv/Kconfig >>>>> @@ -94,13 +94,13 @@ config BATMAN_ADV_DEBUGFS >>>>> bool "batman-adv debugfs entries" >>>>> depends on BATMAN_ADV >>>>> depends on DEBUG_FS >>>>> - default y >>>>> + default n >>>> >>>> N is the default default. :-) You don't need this line. >>> >>> Hm, looks like this would have to be changed in a lot of places (~782 >>> according to `git grep 'default n$'|wc -l` in my slightly outdated linux- >>> next). Do you want to fix it everywhere? >> >> No, but we can at least not add the new ones... > > But the patch was added to net-next yesterday. DaveM is still too fast for me. :-) > Kind regards, > Sven MBR, Sergei
On Fri, 2018-05-25 at 14:13 +0300, Sergei Shtylyov wrote: > On 5/25/2018 1:50 PM, Sven Eckelmann wrote: > > > [...] > > > > --- a/net/batman-adv/Kconfig > > > > +++ b/net/batman-adv/Kconfig > > > > @@ -94,13 +94,13 @@ config BATMAN_ADV_DEBUGFS > > > > bool "batman-adv debugfs entries" > > > > depends on BATMAN_ADV > > > > depends on DEBUG_FS > > > > - default y > > > > + default n > > > > > > N is the default default. :-) You don't need this line. > > > > Hm, looks like this would have to be changed in a lot of places (~782 > > according to `git grep 'default n$'|wc -l` in my slightly outdated linux- > > next). Do you want to fix it everywhere? > > No, but we can at least not add the new ones... > > > Might be good to get this integrated > > in checkpatch.pl when this will become a new policy. > > Adding Joe Perches. Joe, can you add a check for "default n"? OK. This also improves the Kconfig boolean->bool test above as it's broken for multiple section Kconfig files with help texts. --- scripts/checkpatch.pl | 19 ++++++++++++++++--- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index baddac9379f0..1f980be4950b 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2888,9 +2888,22 @@ sub process { # discourage the use of boolean for type definition attributes of Kconfig options if ($realfile =~ /Kconfig/ && - $line =~ /^\+\s*\bboolean\b/) { - WARN("CONFIG_TYPE_BOOLEAN", - "Use of boolean is deprecated, please use bool instead.\n" . $herecurr); + $rawline =~ /^\+\s*\bboolean\b/) { + if (WARN("CONFIG_TYPE_BOOLEAN", + "Use of boolean is deprecated, please use bool instead.\n" . $herecurr) && + $fix) { + $fixed[$fixlinenr] =~ s/\bboolean\b/bool/; + } + } + +# discourage the use of 'default n' in Kconfig files as that's the default + if ($realfile =~ /Kconfig/ && + $rawline =~ /^\+\s*default\s+n\s*$/) { + if (WARN("CONFIG_DEFAULT_N", + "Unnecessary Use of 'default n'\n" . $herecurr) && + $fix) { + fix_delete_line($fixlinenr, $rawline); + } } if (($realfile =~ /Makefile.*/ || $realfile =~ /Kbuild.*/) &&
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> Date: Fri, 25 May 2018 18:56:09 +0300 > On 05/25/2018 02:15 PM, Sven Eckelmann wrote: > >>>> [...] >>>>>> --- a/net/batman-adv/Kconfig >>>>>> +++ b/net/batman-adv/Kconfig >>>>>> @@ -94,13 +94,13 @@ config BATMAN_ADV_DEBUGFS >>>>>> bool "batman-adv debugfs entries" >>>>>> depends on BATMAN_ADV >>>>>> depends on DEBUG_FS >>>>>> - default y >>>>>> + default n >>>>> >>>>> N is the default default. :-) You don't need this line. >>>> >>>> Hm, looks like this would have to be changed in a lot of places (~782 >>>> according to `git grep 'default n$'|wc -l` in my slightly outdated linux- >>>> next). Do you want to fix it everywhere? >>> >>> No, but we can at least not add the new ones... >> >> But the patch was added to net-next yesterday. > > DaveM is still too fast for me. :-) No worries, just let's get a patch to remove the line.
diff --git a/net/batman-adv/Kconfig b/net/batman-adv/Kconfig index e4e2e02b7380..bee034a95208 100644 --- a/net/batman-adv/Kconfig +++ b/net/batman-adv/Kconfig @@ -94,13 +94,13 @@ config BATMAN_ADV_DEBUGFS bool "batman-adv debugfs entries" depends on BATMAN_ADV depends on DEBUG_FS - default y + default n help Enable this to export routing related debug tables via debugfs. The information for each soft-interface and used hard-interface can be found under batman_adv/ - If unsure, say Y. + If unsure, say N. config BATMAN_ADV_DEBUG bool "B.A.T.M.A.N. debugging"