diff mbox series

batman-adv: enable MCAST by default at compile time

Message ID 20181106090150.2905-1-linus.luessing@c0d3.blue
State Accepted, archived
Commit 820a6641d72b297d6dd4d913461d808170d2da6f
Delegated to: Simon Wunderlich
Headers show
Series batman-adv: enable MCAST by default at compile time | expand

Commit Message

Linus Lüssing Nov. 6, 2018, 9:01 a.m. UTC
Thanks to rigorous testing in wireless community mesh networks several
issues with multicast entries in the translation table were found and
fixed in the last 1.5 years. Now we see the first larger networks
(a few hundred nodes) with a batman-adv version with multicast
optimizations enabled arising, with no TT / multicast optimization
related issues so far.

Therefore it seems safe to enable multicast optimizations by default not
only in kernel module builds but also for in-kernel builds.

Signed-off-by: Linus Lüssing <linus.luessing@c0d3.blue>
---
 net/batman-adv/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Sven Eckelmann Nov. 6, 2018, 9:12 a.m. UTC | #1
On Dienstag, 6. November 2018 10:01:50 CET Linus Lüssing wrote:
> Thanks to rigorous testing in wireless community mesh networks several
> issues with multicast entries in the translation table were found and
> fixed in the last 1.5 years. Now we see the first larger networks
> (a few hundred nodes) with a batman-adv version with multicast
> optimizations enabled arising, with no TT / multicast optimization
> related issues so far.
> 
> Therefore it seems safe to enable multicast optimizations by default not
> only in kernel module builds but also for in-kernel builds.
> 
> Signed-off-by: Linus Lüssing <linus.luessing@c0d3.blue>
> ---
>  net/batman-adv/Kconfig | 1 +
>  1 file changed, 1 insertion(+)

I have now queued it up for the upcoming net-next PR. This patch should be 
merged after we released batman-adv 2018.4. But my original patch to disable 
the MCAST optimization by default [1] for 2018.4 was already reverted. The 
2018.4 release will therefore still have MCAST enabled by default for the out-
of-tree module.

Thanks,
	Sven

[1] https://patchwork.open-mesh.org/patch/17435/
diff mbox series

Patch

diff --git a/net/batman-adv/Kconfig b/net/batman-adv/Kconfig
index f75816f5..b70b96cd 100644
--- a/net/batman-adv/Kconfig
+++ b/net/batman-adv/Kconfig
@@ -82,6 +82,7 @@  config BATMAN_ADV_NC
 config BATMAN_ADV_MCAST
 	bool "Multicast optimisation"
 	depends on BATMAN_ADV && INET && !(BRIDGE=m && BATMAN_ADV=y)
+	default y
 	help
 	  This option enables the multicast optimisation which aims to
 	  reduce the air overhead while improving the reliability of