From patchwork Fri May 24 09:59:27 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeremy Sowden X-Patchwork-Id: 17923 X-Patchwork-Delegate: sw@simonwunderlich.de Return-Path: X-Original-To: patchwork@open-mesh.org Delivered-To: patchwork@open-mesh.org Received: from open-mesh.org (localhost [IPv6:::1]) by open-mesh.org (Postfix) with ESMTP id C5D0C81A54; Fri, 24 May 2019 12:40:20 +0200 (CEST) Received: from kadath.azazel.net (kadath.azazel.net [IPv6:2001:8b0:135f:bcd1:e2cb:4eff:fedf:e608]) by open-mesh.org (Postfix) with ESMTPS id F37768055D for ; Fri, 24 May 2019 12:40:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=azazel.net; s=20190108; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=VLi+bEG12+9e9R8ebYCZTJH1S8XSZcXZWJX7myl/K4c=; b=EwOULvuGhZQlPLPKIKuDhwVM2U wQ7XWFAzPJdT2u7fY61/VbTByw8FNmwVFIMF38OwlcNrkYr4Ddwbj6zH3OyXMRbeZ4QRNe0mbqu8O QkUljYOrVIPe0tYCxwYGRFXSu5GviLidjt28MF1/+8W9A037jESgyD1zMgHz9SrIzx4lfZn3yuBf1 vP8wHoBYPY2AG/gC0y/M4Zg9YMgzsANdUuVmZtMvk/8Hr9ov/ALvLXXJtJKRPNk85lR3h5jbIpe7e JcIAIYK3HbyvoQoyUACawUwFQojed8Bvmc/REZGB1xtV2zwSFnVqrlr5aMToXVCHhNyhZW6/oJEPt TpfGCrCA==; Received: from ulthar.dreamlands ([192.168.96.2]) by kadath.azazel.net with esmtp (Exim 4.89) (envelope-from ) id 1hU6z1-0002cj-F5; Fri, 24 May 2019 10:59:27 +0100 From: Jeremy Sowden To: b.a.t.m.a.n@lists.open-mesh.org, netdev@vger.kernel.org, Marek Lindner , Simon Wunderlich , Antonio Quartulli , "David S. Miller" Subject: [PATCH net v2] batman-adv: fix for leaked TVLV handler. Date: Fri, 24 May 2019 10:59:27 +0100 Message-Id: <20190524095927.31817-1-jeremy@azazel.net> X-Mailer: git-send-email 2.20.1 In-Reply-To: <3325808.M3JPgbICzP@bentobox> References: <3325808.M3JPgbICzP@bentobox> MIME-Version: 1.0 X-SA-Exim-Connect-IP: 192.168.96.2 X-SA-Exim-Mail-From: jeremy@azazel.net X-SA-Exim-Scanned: No (on kadath.azazel.net); SAEximRunCond expanded to false X-BeenThere: b.a.t.m.a.n@lists.open-mesh.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The list for a Better Approach To Mobile Ad-hoc Networking List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: The list for a Better Approach To Mobile Ad-hoc Networking Cc: syzbot+d454a826e670502484b8@syzkaller.appspotmail.com Errors-To: b.a.t.m.a.n-bounces@lists.open-mesh.org Sender: "B.A.T.M.A.N" A handler for BATADV_TVLV_ROAM was being registered when the translation-table was initialized, but not unregistered when the translation-table was freed. Unregister it. Fixes: 122edaa05940 ("batman-adv: tvlv - convert roaming adv packet to use tvlv unicast packets") Reported-by: syzbot+d454a826e670502484b8@syzkaller.appspotmail.com Reviewed-by: Sven Eckelmann Signed-off-by: Jeremy Sowden --- Since v1. * Added "Fixes:" tag. * Added "Reviewed-by:" tag. * Changed prefix to "batman-adv:". net/batman-adv/translation-table.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/batman-adv/translation-table.c b/net/batman-adv/translation-table.c index 1ddfd5e011ee..8a482c5ec67b 100644 --- a/net/batman-adv/translation-table.c +++ b/net/batman-adv/translation-table.c @@ -3813,6 +3813,8 @@ static void batadv_tt_purge(struct work_struct *work) */ void batadv_tt_free(struct batadv_priv *bat_priv) { + batadv_tvlv_handler_unregister(bat_priv, BATADV_TVLV_ROAM, 1); + batadv_tvlv_container_unregister(bat_priv, BATADV_TVLV_TT, 1); batadv_tvlv_handler_unregister(bat_priv, BATADV_TVLV_TT, 1);