| Message ID | 20190707201922.13997-1-sven@narfation.org |
|---|---|
| State | Accepted, archived |
| Commit | d1de7f7aa316d6f7b3268f61afa88f5d2c1a5db5 |
| Delegated to: | Simon Wunderlich |
| Headers | show |
| Series | [maint] batman-adv: Fix netlink dumping of all mcast_flags buckets | expand |
diff --git a/net/batman-adv/multicast.c b/net/batman-adv/multicast.c index 67d7f830..a3488cfb 100644 --- a/net/batman-adv/multicast.c +++ b/net/batman-adv/multicast.c @@ -2303,7 +2303,7 @@ __batadv_mcast_flags_dump(struct sk_buff *msg, u32 portid, while (bucket_tmp < hash->size) { if (batadv_mcast_flags_dump_bucket(msg, portid, cb, hash, - *bucket, &idx_tmp)) + bucket_tmp, &idx_tmp)) break; bucket_tmp++;
The bucket variable is only updated outside the loop over the mcast_flags buckets. It will only be updated during a dumping run when the dumping has to be interrupted and a new message has to be started. This could result in repeated or missing entries when the multicast flags are dumped to userspace. Fixes: 06c82b7b15b1 ("batman-adv: Add inconsistent multicast netlink dump detection") Signed-off-by: Sven Eckelmann <sven@narfation.org> --- net/batman-adv/multicast.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)