diff mbox series

alfred: vis: Fix ifindex check when registering interface

Message ID 20190802063553.5666-1-sven@narfation.org
State Accepted, archived
Commit 0e0fcc5bca8159ad5e96f8d8165afbbae5ec95a5
Delegated to: Simon Wunderlich
Headers
Series alfred: vis: Fix ifindex check when registering interface |

Commit Message

Sven Eckelmann Aug. 2, 2019, 6:35 a.m. UTC 
  The return value of if_nametoindex should be checked before the rtnl query
is send to the kernel. Otherwise we might try to operate on an ifindex
which doesn't exist in the kernel - which will never register any interface.

Fixes: a34f044de561 ("alfred: vis: Use rtnl to query list of hardifs of meshif")
Signed-off-by: Sven Eckelmann <sven@narfation.org>
---
 vis/vis.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/vis/vis.c b/vis/vis.c
index 8df3056..cdc5524 100644
--- a/vis/vis.c
+++ b/vis/vis.c
@@ -617,7 +617,7 @@  static int register_interfaces(struct globals *globals)
 	};
 
 	register_arg.ifindex = if_nametoindex(globals->interface);
-	if (!globals->interface)
+	if (!register_arg.ifindex)
 		return EXIT_FAILURE;