[v3,2/3] batman-adv: bcast: avoid skb-copy for (re)queued broadcasts
Commit Message
Broadcast packets send via batadv_send_outstanding_bcast_packet() were
originally copied in batadv_forw_bcast_packet_to_list() before being
queued. And after that only the ethernet header will be pushed through
batadv_send_broadcast_skb()->batadv_send_skb_packet() which works safely
on skb clones as it uses batadv_skb_head_push()->skb_cow_head().
Signed-off-by: Linus Lüssing <linus.luessing@c0d3.blue>
---
Changelog v3:
* newly added this patch, to move skb_copy()->skb_clone() change from
PATCH 01/03 to a separate patch with its own explanation
net/batman-adv/send.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
@@ -1072,7 +1072,7 @@ static void batadv_send_outstanding_bcast_packet(struct work_struct *work)
}
/* send a copy of the saved skb */
- skb1 = skb_copy(forw_packet->skb, GFP_ATOMIC);
+ skb1 = skb_clone(forw_packet->skb, GFP_ATOMIC);
if (!skb1)
goto out;