[v3,2/3] batman-adv: bcast: avoid skb-copy for (re)queued broadcasts

Message ID 20210516223309.12596-2-linus.luessing@c0d3.blue (mailing list archive)
State Accepted, archived
Delegated to: Sven Eckelmann
Series [v3,1/3] batman-adv: bcast: queue per interface, if needed |

Commit Message

Linus Lüssing May 16, 2021, 10:33 p.m. UTC
  Broadcast packets send via batadv_send_outstanding_bcast_packet() were
originally copied in batadv_forw_bcast_packet_to_list() before being
queued. And after that only the ethernet header will be pushed through
batadv_send_broadcast_skb()->batadv_send_skb_packet() which works safely
on skb clones as it uses batadv_skb_head_push()->skb_cow_head().

Signed-off-by: Linus Lüssing <linus.luessing@c0d3.blue>

Changelog v3:

* newly added this patch, to move skb_copy()->skb_clone() change from
  PATCH 01/03 to a separate patch with its own explanation

 net/batman-adv/send.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


diff --git a/net/batman-adv/send.c b/net/batman-adv/send.c
index 07b0ba26..0b9dd29d 100644
--- a/net/batman-adv/send.c
+++ b/net/batman-adv/send.c
@@ -1072,7 +1072,7 @@  static void batadv_send_outstanding_bcast_packet(struct work_struct *work)
 	/* send a copy of the saved skb */
-	skb1 = skb_copy(forw_packet->skb, GFP_ATOMIC);
+	skb1 = skb_clone(forw_packet->skb, GFP_ATOMIC);
 	if (!skb1)
 		goto out;