diff mbox series

[PATCHv2] net/batman-adv:remove unneeded variable

Message ID 20211210094206.426283-1-chi.minghao@zte.com.cn
State Not Applicable, archived
Delegated to: Simon Wunderlich
Headers
Series [PATCHv2] net/batman-adv:remove unneeded variable |

Commit Message

cgel.zte@gmail.com Dec. 10, 2021, 9:42 a.m. UTC 
  From: Minghao Chi <chi.minghao@zte.com.cn>

Return status directly from function called.
change since v1: zealci@zte.com.cm
             v2: zealci@zte.com.cn
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
---
 net/batman-adv/network-coding.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

Comments

Sven Eckelmann Dec. 10, 2021, 9:51 a.m. UTC | #1 
On Friday, 10 December 2021 10:42:06 CET cgel.zte@gmail.com wrote:
> From: Minghao Chi <chi.minghao@zte.com.cn>
> 
> Return status directly from function called.
> change since v1: zealci@zte.com.cm
>              v2: zealci@zte.com.cn
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
> ---

This is wrong:

1. the patch was already applied
2. the patch history doesn't belong in the commit message
3. there is still an alignment problem
4. if you use -v in git-format-patch then it should be "PATCH v2" and not 
   "PATCHv2" (otherwise it will not be parsed correctly by patchwork)
5. The alignment problem is still there
6. the subject is also not following the normal formatting style

Kind regards,
	Sven
diff mbox series

Patch

diff --git a/net/batman-adv/network-coding.c b/net/batman-adv/network-coding.c
index 0a7f1d36a6a8..0c300476d335 100644
--- a/net/batman-adv/network-coding.c
+++ b/net/batman-adv/network-coding.c
@@ -58,13 +58,9 @@  static int batadv_nc_recv_coded_packet(struct sk_buff *skb,
  */
 int __init batadv_nc_init(void)
 {
-	int ret;
-
 	/* Register our packet type */
-	ret = batadv_recv_handler_register(BATADV_CODED,
+	return batadv_recv_handler_register(BATADV_CODED,
 					   batadv_nc_recv_coded_packet);
-
-	return ret;
 }
 
 /**