From patchwork Wed Feb 18 11:26:43 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marek Lindner X-Patchwork-Id: 4347 Return-Path: Received-SPF: Softfail (domain owner discourages use of this host) identity=mailfrom; client-ip=5.148.176.57; helo=s1.neomailbox.net; envelope-from=mareklindner@neomailbox.ch; receiver=b.a.t.m.a.n@lists.open-mesh.org Received: from s1.neomailbox.net (s1.neomailbox.net [5.148.176.57]) by open-mesh.org (Postfix) with ESMTPS id 34B68601455 for ; Wed, 18 Feb 2015 12:26:49 +0100 (CET) From: Marek Lindner To: The list for a Better Approach To Mobile Ad-hoc Networking Date: Wed, 18 Feb 2015 19:26:43 +0800 Message-ID: <2282256.5kOumjqyC5@voltaire> User-Agent: KMail/4.14.2 (Linux/3.16.0-4-amd64; KDE/4.14.2; x86_64; ; ) In-Reply-To: References: MIME-Version: 1.0 Subject: Re: [B.A.T.M.A.N.] Question concerning batman-adv bug #173 "Mesh packets on bat0" X-BeenThere: b.a.t.m.a.n@lists.open-mesh.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: The list for a Better Approach To Mobile Ad-hoc Networking List-Id: The list for a Better Approach To Mobile Ad-hoc Networking List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Feb 2015 11:26:50 -0000 On Wednesday, February 18, 2015 08:35:49 Andreas Pape wrote: > I'm interested if there is any progress concerning the bug entry #173 ( > http://www.open-mesh.org/issues/173). > > I'm currently observing something similiar on an embedded system running > an older kernel 2.6.32.26. Batman-adv versions up to 2013.1.0 work > flawlessly out of the box. All newer versions show the phenomenon > described in bug #173. > In my case I found out, that the batadv_batman_skb_recv function is never > called again as soon as I add bat0 to the bridge interface I use. > If I use the bat0 interface outside a bridge, everything works fine up to > the latest version I tested (which was 2014.4.0) even with the old kernel > version. Can you please try the attached patch and check whether it makes any difference? If the symptoms are the same, please provide step-by-step instructions how you create / configure your interfaces. Thanks, Marek From 97dd927aca3747e1a054303638011f93373c96bf Mon Sep 17 00:00:00 2001 From: Marek Lindner Date: Wed, 18 Feb 2015 19:24:06 +0800 Subject: [PATCH] do not call master->netdev_ops->ndo_init --- hard-interface.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hard-interface.c b/hard-interface.c index fbda6b5..010a403 100644 --- a/hard-interface.c +++ b/hard-interface.c @@ -349,7 +349,7 @@ batadv_hardif_deactivate_interface(struct batadv_hard_iface *hard_iface) * is free'd and master can correctly change its internal state. * Return 0 on success, a negative value representing the error otherwise */ -static int batadv_master_del_slave(struct batadv_hard_iface *slave, +/*tatic int batadv_master_del_slave(struct batadv_hard_iface *slave, struct net_device *master) { int ret; @@ -362,7 +362,7 @@ static int batadv_master_del_slave(struct batadv_hard_iface *slave, ret = master->netdev_ops->ndo_del_slave(master, slave->net_dev); return ret; -} +}*/ int batadv_hardif_enable_interface(struct batadv_hard_iface *hard_iface, const char *iface_name) @@ -403,10 +403,10 @@ int batadv_hardif_enable_interface(struct batadv_hard_iface *hard_iface, /* check if the interface is enslaved in another virtual one and * in that case unlink it first */ - master = netdev_master_upper_dev_get(hard_iface->net_dev); + /* master = netdev_master_upper_dev_get(hard_iface->net_dev); ret = batadv_master_del_slave(hard_iface, master); if (ret) - goto err_dev; + goto err_dev; */ hard_iface->soft_iface = soft_iface; bat_priv = netdev_priv(hard_iface->soft_iface); -- 2.1.4