Message ID | CAPgLHd8jAk-4C1w4Z-q=WeMT_SgB99HCrGCtEPa5Xe4VYnZCOA@mail.gmail.com |
---|---|
State | Superseded, archived |
Headers | show |
On Tue, Aug 28, 2012 at 09:06:08PM +0800, Wei Yongjun wrote: > From: Wei Yongjun <yongjun_wei@trendmicro.com.cn> > > Remove pointless conditional before kfree_skb(). > > Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn> Acked-by: Antonio Quartulli <ordex@autistici.org> Thank you Wei! Regards,
diff --git a/net/batman-adv/send.c b/net/batman-adv/send.c index 3b4b2da..534dc46 100644 --- a/net/batman-adv/send.c +++ b/net/batman-adv/send.c @@ -99,8 +99,7 @@ void batadv_schedule_bat_ogm(struct batadv_hard_iface *hard_iface) static void batadv_forw_packet_free(struct batadv_forw_packet *forw_packet) { - if (forw_packet->skb) - kfree_skb(forw_packet->skb); + kfree_skb(forw_packet->skb); if (forw_packet->if_incoming) batadv_hardif_free_ref(forw_packet->if_incoming); kfree(forw_packet);