From patchwork Wed Jun 17 07:30:34 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Linus_L=C3=BCssing?= X-Patchwork-Id: 18121 X-Patchwork-Delegate: sw@simonwunderlich.de Return-Path: X-Original-To: patchwork@open-mesh.org Delivered-To: patchwork@open-mesh.org Received: from diktynna.open-mesh.org (localhost [IPv6:::1]) by diktynna.open-mesh.org (Postfix) with ESMTP id 499E4815AF; Wed, 17 Jun 2020 09:31:22 +0200 (CEST) Received: from mail.aperture-lab.de (mail.aperture-lab.de [138.201.29.205]) by diktynna.open-mesh.org (Postfix) with ESMTPS id A7C9C80C80 for ; Wed, 17 Jun 2020 09:31:18 +0200 (CEST) From: =?utf-8?q?Linus_L=C3=BCssing?= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=c0d3.blue; s=2018; t=1592379078; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ru3cQ/v1mcerqDaVdnD06xJ1izSX7soULZYp2swV5ng=; b=gIefJYvXz2+cJzBjhZw27vpRrOPkjrcCJud8dX/EKnZmImJz/LN1k0PzmRPEPZousUcorx zR6uXVH7T2Mbqw2/6sIrSOMRQAw+YDDgxR1CtxqbAALGe6FjM696ODH3rCw8SvmutunlgC JWm0K3fr6Bcvv4FsKs/8AJ6+yUXauX1G/kainC6+l09oSQozMsVdWbHRC+xkfs6UphbXv7 l9GQl2CwVt7Qj/8idjUnKB5MBidfjK+ULyjGIL4ADZjx6pIEBbLOOWYp83mULEYn20p2IY XT1agm9cSiSRGh9mTZ5uHLqsKTBdU+vC2bRG8p/0i+gw5/4qdRUHYZGlHFfO4g== To: Johannes Berg Subject: [PATCH v3] iw: mesh: add mesh_param "mesh_nolearn" to skip path discovery Date: Wed, 17 Jun 2020 09:30:34 +0200 Message-Id: <20200617073034.26149-2-linus.luessing@c0d3.blue> In-Reply-To: <20200617073034.26149-1-linus.luessing@c0d3.blue> References: <20200617073034.26149-1-linus.luessing@c0d3.blue> MIME-Version: 1.0 Authentication-Results: ORIGINATING; auth=pass smtp.auth=linus.luessing@c0d3.blue smtp.mailfrom=linus.luessing@c0d3.blue ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=open-mesh.org; s=20121; t=1592379078; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ru3cQ/v1mcerqDaVdnD06xJ1izSX7soULZYp2swV5ng=; b=DWquNdukR+JPkdLjX8m6F8Mpf9kfde6uRBL05lvidkqZj6tOEiTcOpi2bigJKWLytpjis0 9gRPoGWfAivHrl6PaHWHAWECqMOgUtZBtrWEpTRxTrRZ82VjAHLnLHuuFGyM8EprzSAvVO sOpfQ0F38zTOPZ0xKOSxYP3i0yH3Q8E= ARC-Seal: i=1; s=20121; d=open-mesh.org; t=1592379078; a=rsa-sha256; cv=none; b=JaVNZPiXKTLrBcMwQA6gcs7EBlZn3SdHG5rN/EOkyaQn9pfIslIV8rRQNE6QDp9JnPBGRI jkvvhJ3IbOSwyDU4NodbkCVxGHM2erpUYMp/G7NGUWyeZhGQAGtVhbQLWNzIpt1sR36niU X3Uql6JxUQRu0a0Q3tpGOklGDrRF3Mk= ARC-Authentication-Results: i=1; diktynna.open-mesh.org; dkim=none (invalid DKIM record) header.d=c0d3.blue header.s=2018 header.b=gIefJYvX; spf=none (diktynna.open-mesh.org: domain of linus.luessing@c0d3.blue has no SPF policy when checking 138.201.29.205) smtp.mailfrom=linus.luessing@c0d3.blue Message-ID-Hash: QT4BQ54I244LOQWCVGEP5YYEX4PQOO7L X-Message-ID-Hash: QT4BQ54I244LOQWCVGEP5YYEX4PQOO7L X-MailFrom: linus.luessing@c0d3.blue X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-b.a.t.m.a.n.lists.open-mesh.org-0; header-match-b.a.t.m.a.n.lists.open-mesh.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: linux-wireless@vger.kernel.org, b.a.t.m.a.n@lists.open-mesh.org, =?utf-8?q?Linus_L=C3=BCssing?= X-Mailman-Version: 3.2.1 Precedence: list Reply-To: The list for a Better Approach To Mobile Ad-hoc Networking List-Id: The list for a Better Approach To Mobile Ad-hoc Networking Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: From: Linus Lüssing Currently, before being able to forward a packet between two 802.11s nodes, both a PLINK handshake is performed upon receiving a beacon and then later a PREQ/PREP exchange for path discovery is performed on demand upon receiving a data frame to forward. When running a mesh protocol on top of an 802.11s interface, like batman-adv, we do not need the multi-hop mesh routing capabilities of 802.11s and usually set mesh_fwding=0. However, even with mesh_fwding=0 the PREQ/PREP path discovery is still performed on demand. Even though in this scenario the next hop PREQ/PREP will determine is always the direct 11s neighbor node. The new mesh_nolearn parameter allows to skip the PREQ/PREP exchange in this scenario, leading to a reduced delay, reduced packet buffering and simplifies HWMP in general. mesh_nolearn is still rather conservative in that if the packet destination is not a direct 11s neighbor, it will fall back to PREQ/PREP path discovery. For normal, multi-hop 802.11s mesh routing it is usually not advisable to enable mesh_nolearn as a transmission to a direct but distant neighbor might be worse than reaching that same node via a more robust / higher throughput etc. multi-hop path. Cc: Sven Eckelmann Cc: Simon Wunderlich Signed-off-by: Linus Lüssing --- Changelog v2/v3: * unchanged mesh.c | 2 ++ nl80211.h | 7 +++++++ 2 files changed, 9 insertions(+) diff --git a/mesh.c b/mesh.c index 0650d0c..48bbc3f 100644 --- a/mesh.c +++ b/mesh.c @@ -264,6 +264,8 @@ static const struct mesh_param_descr _mesh_param_descrs[] = _my_nla_put_u16, _parse_u16, _print_u16_in_TUs}, {"mesh_plink_timeout", NL80211_MESHCONF_PLINK_TIMEOUT, _my_nla_put_u32, _parse_u32, _print_u32_in_seconds}, + {"mesh_nolearn", NL80211_MESHCONF_NOLEARN, + _my_nla_put_u8, _parse_u8_as_bool, _print_u8}, }; static void print_all_mesh_param_descr(void) diff --git a/nl80211.h b/nl80211.h index c14666b..4c55e89 100644 --- a/nl80211.h +++ b/nl80211.h @@ -4228,6 +4228,12 @@ enum nl80211_mesh_power_mode { * field. If left unset then the mesh formation field will only * advertise such if there is an active root mesh path. * + * @NL80211_MESHCONF_NOLEARN: Try to avoid multi-hop path discovery (e.g. + * PREQ/PREP for HWMP) if the destination is a direct neighbor. Note that + * this might not be the optimal decision as a multi-hop route might be + * better. So if using this setting you will likely also want to disable + * dot11MeshForwarding and use another mesh routing protocol on top. + * * @__NL80211_MESHCONF_ATTR_AFTER_LAST: internal use */ enum nl80211_meshconf_params { @@ -4261,6 +4267,7 @@ enum nl80211_meshconf_params { NL80211_MESHCONF_AWAKE_WINDOW, NL80211_MESHCONF_PLINK_TIMEOUT, NL80211_MESHCONF_CONNECTED_TO_GATE, + NL80211_MESHCONF_NOLEARN, /* keep last */ __NL80211_MESHCONF_ATTR_AFTER_LAST,