From patchwork Sun Mar 18 09:34:29 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sven Eckelmann X-Patchwork-Id: 17306 X-Patchwork-Delegate: sven@narfation.org Return-Path: X-Original-To: patchwork@open-mesh.org Delivered-To: patchwork@open-mesh.org Received: from open-mesh.org (localhost [IPv6:::1]) by open-mesh.org (Postfix) with ESMTP id CBDBC80C5D; Sun, 18 Mar 2018 10:34:34 +0100 (CET) Authentication-Results: open-mesh.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=narfation.org header.i=@narfation.org header.b="rSRmpStP"; dkim-atps=neutral Received: from v3-1039.vlinux.de (narfation.org [79.140.41.39]) by open-mesh.org (Postfix) with ESMTPS id 679B680728 for ; Sun, 18 Mar 2018 10:34:33 +0100 (CET) Received: from sven-desktop.home.narfation.org (p200300C593F00AF90000000000004065.dip0.t-ipconnect.de [IPv6:2003:c5:93f0:af9::4065]) by v3-1039.vlinux.de (Postfix) with ESMTPSA id EC4C811011A; Sun, 18 Mar 2018 10:34:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=narfation.org; s=20121; t=1521365673; bh=G6w4M2lmtFW+iqZvcyy/j/n/u+8P8PjbenaRMCzE4YI=; h=From:To:Cc:Subject:Date:From; b=rSRmpStPSXIYPCSS53JcN8mnfmmiPtyhkXL83lF9sRS0AeAwXBfdnw9tgYq8vSVzI ZceBsxkb6fp2p2jeZwMOdWeQNnvr7kVzVApYiWF0EqEQI1TdiuN5rw9DmJxLPQBmW4 Sk+8KcaUDc9FIo6nw3VTKbodGMZNHmG0aY+Y5WT0= From: Sven Eckelmann To: b.a.t.m.a.n@lists.open-mesh.org Date: Sun, 18 Mar 2018 10:34:29 +0100 Message-Id: <20180318093429.18752-1-sven@narfation.org> X-Mailer: git-send-email 2.16.2 Subject: [B.A.T.M.A.N.] [PATCH] batman-adv: Disable CONFIG_BATMAN_ADV_DEBUGFS by default X-BeenThere: b.a.t.m.a.n@lists.open-mesh.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The list for a Better Approach To Mobile Ad-hoc Networking List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: The list for a Better Approach To Mobile Ad-hoc Networking Errors-To: b.a.t.m.a.n-bounces@lists.open-mesh.org Sender: "B.A.T.M.A.N" All tools which were known to the batman-adv development team are supporting the batman-adv netlink interface since a while. Also debugfs is not supported for batman-adv interfaces in any non-default netns. Thus disabling CONFIG_BATMAN_ADV_DEBUGFS by default should not cause problems on most systems. It is still possible to enable it in case it is still required in a specific setup. Signed-off-by: Sven Eckelmann --- Was already submitted as RFC in https://patchwork.open-mesh.org/patch/16498/ --- Makefile | 2 +- README.external.rst | 2 +- gen-compat-autoconf.sh | 2 +- net/batman-adv/Kconfig | 4 ++-- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/Makefile b/Makefile index fe97d0aa..de607ad9 100644 --- a/Makefile +++ b/Makefile @@ -18,7 +18,7 @@ # read README.external for more information about the configuration # batman-adv DebugFS entries: -export CONFIG_BATMAN_ADV_DEBUGFS=y +export CONFIG_BATMAN_ADV_DEBUGFS=n # B.A.T.M.A.N. debugging: export CONFIG_BATMAN_ADV_DEBUG=n # B.A.T.M.A.N. bridge loop avoidance: diff --git a/README.external.rst b/README.external.rst index 6379b4f5..4a2e9f6a 100644 --- a/README.external.rst +++ b/README.external.rst @@ -43,7 +43,7 @@ option can be set to to y (enabled), n (disabled) or m (build as module). Available options and their possible values are (default marked with an "*") - * ``CONFIG_BATMAN_ADV_DEBUGFS=[y*|n]`` (B.A.T.M.A.N. debugfs entries) + * ``CONFIG_BATMAN_ADV_DEBUGFS=[y|n*]`` (B.A.T.M.A.N. debugfs entries) * ``CONFIG_BATMAN_ADV_DEBUG=[y|n*]`` (B.A.T.M.A.N. debugging) * ``CONFIG_BATMAN_ADV_BLA=[y*|n]`` (B.A.T.M.A.N. bridge loop avoidance) * ``CONFIG_BATMAN_ADV_DAT=[y*|n]`` (B.A.T.M.A.N. Distributed ARP Table) diff --git a/gen-compat-autoconf.sh b/gen-compat-autoconf.sh index 5a4cdefc..071b6ccf 100755 --- a/gen-compat-autoconf.sh +++ b/gen-compat-autoconf.sh @@ -52,7 +52,7 @@ gen_config() { } # write config variables -gen_config 'CONFIG_BATMAN_ADV_DEBUGFS' ${CONFIG_BATMAN_ADV_DEBUGFS:="y"} >> "${TMP}" +gen_config 'CONFIG_BATMAN_ADV_DEBUGFS' ${CONFIG_BATMAN_ADV_DEBUGFS:="n"} >> "${TMP}" gen_config 'CONFIG_BATMAN_ADV_DEBUG' ${CONFIG_BATMAN_ADV_DEBUG:="n"} >> "${TMP}" gen_config 'CONFIG_BATMAN_ADV_BLA' ${CONFIG_BATMAN_ADV_BLA:="y"} >> "${TMP}" gen_config 'CONFIG_BATMAN_ADV_DAT' ${CONFIG_BATMAN_ADV_DAT:="y"} >> "${TMP}" diff --git a/net/batman-adv/Kconfig b/net/batman-adv/Kconfig index e4e2e02b..bee034a9 100644 --- a/net/batman-adv/Kconfig +++ b/net/batman-adv/Kconfig @@ -94,13 +94,13 @@ config BATMAN_ADV_DEBUGFS bool "batman-adv debugfs entries" depends on BATMAN_ADV depends on DEBUG_FS - default y + default n help Enable this to export routing related debug tables via debugfs. The information for each soft-interface and used hard-interface can be found under batman_adv/ - If unsure, say Y. + If unsure, say N. config BATMAN_ADV_DEBUG bool "B.A.T.M.A.N. debugging"