diff mbox

[v4,3/6] batman-adv: statically print gateway table header

Message ID	20160525152736.9031-4-a@unstable.cc (mailing list archive)
State	Accepted, archived
Commit	f8fa1cfa343d5ec4b38760c3051cdd8a3a454005
Delegated to:	Marek Lindner
Headers	Received-SPF: Permerror (SPF Permanent Error: Two or more type TXT spf records found.) identity=mailfrom; client-ip=5.148.176.60; helo=s2.neomailbox.net; envelope-from=a@unstable.cc; receiver=b.a.t.m.a.n@lists.open-mesh.org From: Antonio Quartulli <a@unstable.cc> To: b.a.t.m.a.n@lists.open-mesh.org Date: Wed, 25 May 2016 23:27:33 +0800 Message-Id: <20160525152736.9031-4-a@unstable.cc> In-Reply-To: <20160525152736.9031-1-a@unstable.cc> References: <20160525152736.9031-1-a@unstable.cc> Cc: Antonio Quartulli <a@unstable.cc> Subject: [B.A.T.M.A.N.] [PATCH v4 3/6] batman-adv: statically print gateway table header Precedence: list Reply-To: The list for a Better Approach To Mobile Ad-hoc Networking <b.a.t.m.a.n@lists.open-mesh.org> Errors-To: b.a.t.m.a.n-bounces@lists.open-mesh.org Sender: "B.A.T.M.A.N" <b.a.t.m.a.n-bounces@lists.open-mesh.org>

Commit Message

Antonio Quartulli May 25, 2016, 3:27 p.m. UTC

  To make it easier to search through the code it is better to print static
strings directly instead of using format strings printing constants.

This was addressed in a previous patch, but the Gateway table header
was not updated accordingly.

Signed-off-by: Antonio Quartulli <a@unstable.cc>
---
 net/batman-adv/gateway_client.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Sven Eckelmann May 31, 2016, 5:50 p.m. UTC | #1

On Wednesday 25 May 2016 23:27:33 Antonio Quartulli wrote:
> To make it easier to search through the code it is better to print static
> strings directly instead of using format strings printing constants.
> 
> This was addressed in a previous patch, but the Gateway table header
> was not updated accordingly.
> 
> Signed-off-by: Antonio Quartulli <a@unstable.cc>
> ---

Reviewed-by: Sven Eckelmann <sven@narfation.org>

Kind regards,
	Sven

Marek Lindner June 7, 2016, 6:22 a.m. UTC | #2

On Tuesday, May 31, 2016 19:50:46 Sven Eckelmann wrote:
> On Wednesday 25 May 2016 23:27:33 Antonio Quartulli wrote:
> > To make it easier to search through the code it is better to print static
> > strings directly instead of using format strings printing constants.
> >
> > This was addressed in a previous patch, but the Gateway table header
> > was not updated accordingly.
> >
> > Signed-off-by: Antonio Quartulli <a@unstable.cc>
> > ---
> 
> Reviewed-by: Sven Eckelmann <sven@narfation.org>

Applied in revision f8fa1cf.

Thanks,
Marek

diff mbox

Patch

diff --git a/net/batman-adv/gateway_client.c b/net/batman-adv/gateway_client.c
index e108d45..63a805d 100644
--- a/net/batman-adv/gateway_client.c
+++ b/net/batman-adv/gateway_client.c
@@ -639,8 +639,7 @@  int batadv_gw_client_seq_print_text(struct seq_file *seq, void *offset)
 		goto out;
 
 	seq_printf(seq,
-		   "      %-12s (%s/%i) %17s [%10s]: advertised uplink bandwidth ... [B.A.T.M.A.N. adv %s, MainIF/MAC: %s/%pM (%s)]\n",
-		   "Gateway", "#", BATADV_TQ_MAX_VALUE, "Nexthop", "outgoingIF",
+		   "      Gateway      (#/255)           Nexthop [outgoingIF]: advertised uplink bandwidth ... [B.A.T.M.A.N. adv %s, MainIF/MAC: %s/%pM (%s)]\n",
 		   BATADV_SOURCE_VERSION, primary_if->net_dev->name,
 		   primary_if->net_dev->dev_addr, net_dev->name);