batman-adv: remove unused BATADV_BONDING_TQ_THRESHOLD constant
Commit Message
BATADV_BONDING_TQ_THRESHOLD is not used anymore since the implementation
of the bat_neigh_is_similar_or_better() API function.
Such function uses the more generic BATADV_TQ_SIMILARITY_THRESHOLD
constant.
Therefore, remove definition of the unused BATADV_BONDING_TQ_THRESHOLD
constant.
Signed-off-by: Antonio Quartulli <a@unstable.cc>
---
net/batman-adv/main.h | 5 -----
1 file changed, 5 deletions(-)
Comments
On Tuesday 12 January 2016 09:15:25 Antonio Quartulli wrote:
> BATADV_BONDING_TQ_THRESHOLD is not used anymore since the implementation
> of the bat_neigh_is_similar_or_better() API function.
> Such function uses the more generic BATADV_TQ_SIMILARITY_THRESHOLD
> constant.
>
> Therefore, remove definition of the unused BATADV_BONDING_TQ_THRESHOLD
> constant.
>
> Signed-off-by: Antonio Quartulli <a@unstable.cc>
Just in case somebody else is interested since when it is not used anymore:
a64108267584 ("batman-adv: adapt bonding to use the new API functions")
This is in v2014.0.0/v3.13. So it should be fine to remove it :)
Kind regards,
Sven
On Tuesday, January 12, 2016 09:15:25 Antonio Quartulli wrote:
> BATADV_BONDING_TQ_THRESHOLD is not used anymore since the implementation
> of the bat_neigh_is_similar_or_better() API function.
> Such function uses the more generic BATADV_TQ_SIMILARITY_THRESHOLD
> constant.
>
> Therefore, remove definition of the unused BATADV_BONDING_TQ_THRESHOLD
> constant.
>
> Signed-off-by: Antonio Quartulli <a@unstable.cc>
> ---
> net/batman-adv/main.h | 5 -----
> 1 file changed, 5 deletions(-)
Applied in revision 82b7d70.
Thanks,
Marek
@@ -100,11 +100,6 @@
*/
#define BATADV_TQ_SIMILARITY_THRESHOLD 50
-/* how much worse secondary interfaces may be to be considered as bonding
- * candidates
- */
-#define BATADV_BONDING_TQ_THRESHOLD 50
-
/* should not be bigger than 512 bytes or change the size of
* forw_packet->direct_link_flags
*/