Let the compiler interpret the noreturn situation in restore_and_exit correct

Message ID 20081009073555.GA4544@sven-desktop.lazhur.ath.cx (mailing list archive)
State Accepted, archived
Headers

Commit Message

Sven Eckelmann Oct. 9, 2008, 7:35 a.m. UTC
  It is just implicit that raise will not return in this case because we are in
a sighandler right now. So let call exit always afterwards even if it will
not be reached.

Signed-off-by: Sven Eckelmann <sven.eckelmann@gmx.de>
---
 batman/posix/posix.c |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)
  

Comments

Resul Cetin Oct. 12, 2008, 10:47 p.m. UTC | #1
Hiii,

I followed the configuraition steps
http://www.freifunk-bno.de/wiki/firmware:batman#status_info but withous
success. I have to Linksys with the Freifunk Firmware on them. I installed
the Package "batmand_current_mipsel.ipk" from the site
http://freifunk.schmudde.com/ipkg/.

My problem is, that the two Router cann't recognize each other. In the
Status entry of the neigbour nodes is nothing to see.

Can anybody help me to build the B.A.T.M.A.N. Mesh Network ?

greetings,
E.
  
Don Davis Oct. 13, 2008, 12:55 a.m. UTC | #2
I suggest that you start over and use freifunk with the newest batman 
from https://www.open-mesh.net/batman.  I guess I should ask first: 
where are you and will you be connecting to older versions of batman or 
is it you setting up the mesh?

Here's a pretty thorough walk through for setting up freifunk with the 
newer batman:
http://freifunk-texas.net/ffwalkthrough.html
  

Patch

diff --git a/batman/posix/posix.c b/batman/posix/posix.c
index 4423345..bbeac38 100644
--- a/batman/posix/posix.c
+++ b/batman/posix/posix.c
@@ -497,11 +497,10 @@  void restore_and_exit( uint8_t is_sigsegv ) {
 
 	}
 
-	if (!is_sigsegv)
-		exit(EXIT_FAILURE);
-	else
+	if (is_sigsegv)
 		raise(SIGSEGV);
 
+	exit(EXIT_FAILURE);
 }