diff mbox

batman-adv: remove unused BATADV_BONDING_TQ_THRESHOLD constant

Message ID 1452561325-12947-1-git-send-email-a@unstable.cc (mailing list archive)
State Accepted, archived
Commit 82b7d70d077f662433ccefd7b555a3dd6bc2a9d2
Headers

Commit Message

Antonio Quartulli Jan. 12, 2016, 1:15 a.m. UTC 
  BATADV_BONDING_TQ_THRESHOLD is not used anymore since the implementation
of the bat_neigh_is_similar_or_better() API function.
Such function uses the more generic BATADV_TQ_SIMILARITY_THRESHOLD
constant.

Therefore, remove definition of the unused BATADV_BONDING_TQ_THRESHOLD
constant.

Signed-off-by: Antonio Quartulli <a@unstable.cc>
---
 net/batman-adv/main.h | 5 -----
 1 file changed, 5 deletions(-)

Comments

Sven Eckelmann Jan. 13, 2016, 8:40 a.m. UTC | #1 
On Tuesday 12 January 2016 09:15:25 Antonio Quartulli wrote:
> BATADV_BONDING_TQ_THRESHOLD is not used anymore since the implementation
> of the bat_neigh_is_similar_or_better() API function.
> Such function uses the more generic BATADV_TQ_SIMILARITY_THRESHOLD
> constant.
> 
> Therefore, remove definition of the unused BATADV_BONDING_TQ_THRESHOLD
> constant.
> 
> Signed-off-by: Antonio Quartulli <a@unstable.cc>

Just in case somebody else is interested since when it is not used anymore:

a64108267584 ("batman-adv: adapt bonding to use the new API functions")

This is in v2014.0.0/v3.13. So it should be fine to remove it :)

Kind regards,
	Sven
Marek Lindner Jan. 17, 2016, 8:49 a.m. UTC | #2 
On Tuesday, January 12, 2016 09:15:25 Antonio Quartulli wrote:
> BATADV_BONDING_TQ_THRESHOLD is not used anymore since the implementation
> of the bat_neigh_is_similar_or_better() API function.
> Such function uses the more generic BATADV_TQ_SIMILARITY_THRESHOLD
> constant.
> 
> Therefore, remove definition of the unused BATADV_BONDING_TQ_THRESHOLD
> constant.
> 
> Signed-off-by: Antonio Quartulli <a@unstable.cc>
> ---
>  net/batman-adv/main.h | 5 -----
>  1 file changed, 5 deletions(-)

Applied in revision 82b7d70.

Thanks,
Marek
diff mbox

Patch

diff --git a/net/batman-adv/main.h b/net/batman-adv/main.h
index 32dfc9e..8c01f54 100644
--- a/net/batman-adv/main.h
+++ b/net/batman-adv/main.h
@@ -100,11 +100,6 @@ 
  */
 #define BATADV_TQ_SIMILARITY_THRESHOLD 50
 
-/* how much worse secondary interfaces may be to be considered as bonding
- * candidates
- */
-#define BATADV_BONDING_TQ_THRESHOLD	50
-
 /* should not be bigger than 512 bytes or change the size of
  * forw_packet->direct_link_flags
  */