batman-adv: Disable CONFIG_BATMAN_ADV_DEBUGFS by default
Commit Message
All tools which were known to the batman-adv development team are
supporting the batman-adv netlink interface since a while. Also debugfs is
not supported for batman-adv interfaces in any non-default netns. Thus
disabling CONFIG_BATMAN_ADV_DEBUGFS by default should not cause problems on
most systems. It is still possible to enable it in case it is still
required in a specific setup.
Signed-off-by: Sven Eckelmann <sven@narfation.org>
---
Was already submitted as RFC in https://patchwork.open-mesh.org/patch/16498/
---
Makefile | 2 +-
README.external.rst | 2 +-
gen-compat-autoconf.sh | 2 +-
net/batman-adv/Kconfig | 4 ++--
4 files changed, 5 insertions(+), 5 deletions(-)
Comments
On Sun, Mar 18, 2018 at 10:34:29AM +0100, Sven Eckelmann wrote:
> All tools which were known to the batman-adv development team are
> supporting the batman-adv netlink interface since a while. Also debugfs is
> not supported for batman-adv interfaces in any non-default netns. Thus
> disabling CONFIG_BATMAN_ADV_DEBUGFS by default should not cause problems on
> most systems. It is still possible to enable it in case it is still
> required in a specific setup.
I'm wondering, could this lead to some confusion if package
maintainers of a Linux distro were upgrading the kernel before
upgrading batctl?
Since this patch is not urgent, would it make sentence to delay
this patch for after the next release maybe? That should give
maintainers at least a two months window to upgrade batctl.
And should avoid users being confused of "batctl dc" or
"batctl mf" not working with the batman-adv version their
distro might already ship.
Cheers, Linus
On Sonntag, 18. März 2018 15:39:07 CET Linus Lüssing wrote:
[...]
> Since this patch is not urgent, would it make sentence to delay
> this patch for after the next release maybe? That should give
> maintainers at least a two months window to upgrade batctl.
Ok
Kind regards,
Sven
On Sonntag, 18. März 2018 15:39:07 CEST Linus Lüssing wrote:
> Since this patch is not urgent, would it make sentence to delay
> this patch for after the next release maybe?
Patch was now added as 6f5424896782 [1].
Kind regards,
Sven
[1] https://git.open-mesh.org/batman-adv.git/commit/6f542489678248cc99131f2856158bd2c3989368
@@ -18,7 +18,7 @@
# read README.external for more information about the configuration
# batman-adv DebugFS entries:
-export CONFIG_BATMAN_ADV_DEBUGFS=y
+export CONFIG_BATMAN_ADV_DEBUGFS=n
# B.A.T.M.A.N. debugging:
export CONFIG_BATMAN_ADV_DEBUG=n
# B.A.T.M.A.N. bridge loop avoidance:
@@ -43,7 +43,7 @@ option can be set to to y (enabled), n (disabled) or m (build as
module). Available options and their possible values are
(default marked with an "*")
- * ``CONFIG_BATMAN_ADV_DEBUGFS=[y*|n]`` (B.A.T.M.A.N. debugfs entries)
+ * ``CONFIG_BATMAN_ADV_DEBUGFS=[y|n*]`` (B.A.T.M.A.N. debugfs entries)
* ``CONFIG_BATMAN_ADV_DEBUG=[y|n*]`` (B.A.T.M.A.N. debugging)
* ``CONFIG_BATMAN_ADV_BLA=[y*|n]`` (B.A.T.M.A.N. bridge loop avoidance)
* ``CONFIG_BATMAN_ADV_DAT=[y*|n]`` (B.A.T.M.A.N. Distributed ARP Table)
@@ -52,7 +52,7 @@ gen_config() {
}
# write config variables
-gen_config 'CONFIG_BATMAN_ADV_DEBUGFS' ${CONFIG_BATMAN_ADV_DEBUGFS:="y"} >> "${TMP}"
+gen_config 'CONFIG_BATMAN_ADV_DEBUGFS' ${CONFIG_BATMAN_ADV_DEBUGFS:="n"} >> "${TMP}"
gen_config 'CONFIG_BATMAN_ADV_DEBUG' ${CONFIG_BATMAN_ADV_DEBUG:="n"} >> "${TMP}"
gen_config 'CONFIG_BATMAN_ADV_BLA' ${CONFIG_BATMAN_ADV_BLA:="y"} >> "${TMP}"
gen_config 'CONFIG_BATMAN_ADV_DAT' ${CONFIG_BATMAN_ADV_DAT:="y"} >> "${TMP}"
@@ -94,13 +94,13 @@ config BATMAN_ADV_DEBUGFS
bool "batman-adv debugfs entries"
depends on BATMAN_ADV
depends on DEBUG_FS
- default y
+ default n
help
Enable this to export routing related debug tables via debugfs.
The information for each soft-interface and used hard-interface can be
found under batman_adv/
- If unsure, say Y.
+ If unsure, say N.
config BATMAN_ADV_DEBUG
bool "B.A.T.M.A.N. debugging"